Skip to content

Conversation

@dpebot
Copy link
Collaborator

@dpebot dpebot commented Aug 13, 2020

Brought to you by your friendly Repository Gardener.

@dpebot dpebot force-pushed the dpebot-repositorygardener branch from 0f8c912 to 1b97e0c Compare August 13, 2020 22:11
@samtstern
Copy link
Contributor

Failing with a lot of stuff like this:

* What went wrong:
Execution failed for task ':mlkit:app:checkDebugDuplicateClasses'.
> 1 exception was raised by workers:
  java.lang.RuntimeException: Duplicate class com.google.android.gms.internal.vision.zzbl found in modules jetified-play-services-vision-common-19.1.0-runtime.jar (com.google.android.gms:play-services-vision-common:19.1.0) and jetified-play-services-vision-face-contour-internal-16.0.0-runtime.jar (com.google.android.gms:play-services-vision-face-contour-internal:16.0.0)
  Duplicate class com.google.android.gms.internal.vision.zzbn found in modules jetified-play-services-vision-common-19.1.0-runtime.jar (com.google.android.gms:play-services-vision-common:19.1.0) and jetified-play-services-vision-face-contour-internal-16.0.0-runtime.jar (com.google.android.gms:play-services-vision-face-contour-internal:16.0.0)
  Duplicate class com.google.android.gms.internal.vision.zzbo found in modules jetified-play-services-vision-common-19.1.0-runtime.jar (com.google.android.gms:play-services-vision-common:19.1.0) and jetified-play-services-vision-face-contour-internal-16.0.0-runtime.jar (com.google.android.gms:play-services-vision-face-contour-internal:16.0.0)
  Duplicate class com.google.android.gms.internal.vision.zzbp found in modules jetified-play-services-vision-common-19.1.0-runtime.jar (com.google.android.gms:play-services-vision-common:19.1.0) and jetified-play-services-vision-face-contour-internal-16.0.0-runtime.jar (com.google.android.gms:play-services-vision-face-contour-internal:16.0.0)

MLKit breaking changes are the gift that keeps on giving. @gkaldev do you know why this is happening?

@samtstern samtstern requested a review from gkaldev August 14, 2020 09:32
@dpebot dpebot force-pushed the dpebot-repositorygardener branch 3 times, most recently from e4f5ee4 to 3258aa8 Compare August 16, 2020 22:10
@thatfiredev
Copy link
Member

@samtstern the release notes actually mention this. The recommendation is to also add this dependency:

implementation 'com.google.android.gms:play-services-vision-face-contour-internal:16.0.2'

@dpebot dpebot force-pushed the dpebot-repositorygardener branch from 3258aa8 to 95029d7 Compare August 17, 2020 22:11
@gkaldev
Copy link
Contributor

gkaldev commented Aug 18, 2020

Will push some updates to fix this today--thanks.

@dpebot dpebot force-pushed the dpebot-repositorygardener branch 5 times, most recently from b51d974 to e81b751 Compare August 22, 2020 22:09
@dpebot dpebot force-pushed the dpebot-repositorygardener branch from e81b751 to d9d47d5 Compare August 23, 2020 22:10
Change-Id: I3d16591313889654adc1714ecd516b42d252fd58
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

LiveCamera handling). On device models have been moved to another SDK.

Change-Id: I6d1a04ea5aa5bea333bd248eeb5e6d6619666914
@gkaldev gkaldev force-pushed the dpebot-repositorygardener branch from b5769d4 to e6d0e68 Compare August 24, 2020 14:48
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gkaldev added 3 commits August 24, 2020 11:05
Change-Id: I171f92ad5bcf785b1c880245dadae121c1634d1a
Change-Id: I0cebf5df941227044cd339ee54484d3a2d1b6037
Change-Id: I00c1b3b4b6f41bfb82929ed929f22c3f75fc8745
@ChaseMax77
Copy link

Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants