-
Notifications
You must be signed in to change notification settings - Fork 373
fix(js) Fix next.js warnings related to firebase #3459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26f2160
to
3346d2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Can you describe how you tested this change?
PS: Sorry apparently |
Can you make sure that you can initialize firebase telemetry with the environment variable: And that if you have both a direct call to Docs for reference: |
Thanks for the pointer. I can confirm that the solution with import() appears to be working with |
@schnecle let me know if there is anything else I should test or do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for running the extra tests!
Thank you for pointing it out! |
The warnings in #3160, #928 and #935 are primarily webpack related and can be mitigated using webpack magic comments. This PR solves the firebase related warnings
Checklist (if applicable):