Skip to content

Conversation

marcelfolaron
Copy link
Contributor

@marcelfolaron marcelfolaron commented Aug 20, 2025

The warnings in #3160, #928 and #935 are primarily webpack related and can be mitigated using webpack magic comments. This PR solves the firebase related warnings

Checklist (if applicable):

@marcelfolaron marcelfolaron changed the title fix(js) Fix next js warnings related to firebase fix(js) Fix next.js warnings related to firebase Aug 20, 2025
@pavelgj pavelgj requested review from schnecle and pavelgj August 20, 2025 14:41
Copy link
Contributor

@schnecle schnecle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you describe how you tested this change?

@marcelfolaron
Copy link
Contributor Author

Nice! Can you describe how you tested this change?

Mainly by running the use case @mbleigh used here: #3160
Anything in particular you'd want me to test?

@marcelfolaron
Copy link
Contributor Author

PS: Sorry apparently require cannot be used in this way and so we'd need to use import. (which I had before)

@schnecle
Copy link
Contributor

Nice! Can you describe how you tested this change?

Mainly by running the use case @mbleigh used here: #3160 Anything in particular you'd want me to test?

Can you make sure that you can initialize firebase telemetry with the environment variable:
export ENABLE_FIREBASE_MONITORING=true

And that if you have both a direct call to enableFirebaseTelemetry() that overrides configuration and ENABLE_FIREBASE_MONITORING=true, the overriding configuration wins?

Docs for reference:

@marcelfolaron
Copy link
Contributor Author

marcelfolaron commented Aug 20, 2025

Nice! Can you describe how you tested this change?

Mainly by running the use case @mbleigh used here: #3160 Anything in particular you'd want me to test?

Can you make sure that you can initialize firebase telemetry with the environment variable: export ENABLE_FIREBASE_MONITORING=true

And that if you have both a direct call to enableFirebaseTelemetry() that overrides configuration and ENABLE_FIREBASE_MONITORING=true, the overriding configuration wins?

Docs for reference:

Thanks for the pointer. I can confirm that the solution with import() appears to be working with ENABLE_FIREBASE_MONITORING=true as well as enableFirebaseTelemetry() including the precedence test.

@marcelfolaron marcelfolaron requested a review from schnecle August 20, 2025 18:33
@marcelfolaron
Copy link
Contributor Author

@schnecle let me know if there is anything else I should test or do.

Copy link
Contributor

@schnecle schnecle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for running the extra tests!

@marcelfolaron
Copy link
Contributor Author

Thank you for pointing it out!

@pavelgj pavelgj merged commit 3eaab0e into firebase:main Aug 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants