fix(js):Add precondition as option configuration #3426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mambisi
changed the title
mambisi
changed the title
|
Thanks for the fix, I'm kinda torn on this. Do we really need this to be a separate argument to the plugin interface? I think the API key checking can be handled in the initializer, resolver methods respectively. WDYT @pavelgj ? |
|
I see it. The apiKey needs to be resolved before the client object is constructed, so this has to happen before |
ssbushi
reviewed
Aug 20, 2025
| ...options, | ||
| precondition: async () => { |
There was a problem hiding this comment.
one way I see this working is if this is not just a precondition but aresolveOptions function. It should return the resolved options which can be used to create the OpenAI client.
There was a problem hiding this comment.
that should be good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes firebase deployment error: When deploying firebase cloud functions fails
i functions: Loading and analyzing source code for codebase default to determine what to deploydue to checking the api keys in environmental variable before deployed.