fix: Fix for AbortSignal value of "this" issue #3394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stripUndefined will remove all undefined parameters from an object however AbortSignal (per standard) has properties that are valid undefined. Skipping the strip for AbortSignal fixes the issue.
|
@marcelfolaron thank you!! I was banging my head against this earlier in the week. This LGTM, but looping in @pavelgj as well. |
|
@marcelfolaron would you mind doing an |
Ah, missed that one. Pushed the updated version
This was a doozy but since I was encountering that as well it was a good way to start diving deeper and contributing :) |
pavelgj
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stripUndefined will remove all undefined parameters from an object however that breaks the prototype chain.
AbortSignal being a native node.js object shouldn't be processed like that. It has properties that are valid if undefined.
Skipping the strip for AbortSignal fixes the issue.
Checklist (if applicable):