feat(go): update telemetry #3264
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprovider if exists
…into jh-go-telemetry
huangjeff5
commented
Aug 19, 2025
huangjeff5
commented
Aug 19, 2025
| g, err := genkit.Init(ctx) | ||
| if err != nil { | ||
| return err | ||
| // [START enablecustom] |
There was a problem hiding this comment.
unclear on exactly how START / END works and how it impacts docs
huangjeff5
commented
Aug 20, 2025
| @@ -26,62 +26,131 @@ import ( | |||
| "go.opentelemetry.io/otel/sdk/trace" | |||
There was a problem hiding this comment.
not exaclty sure how these doc snippets work; need to make sure they display well
apascal07
reviewed
Aug 26, 2025
go/core/tracing/tracing.go
Outdated
| } | ||
|
|
||
| // RunInNewSpan runs f on input in a new span with the provided metadata. | ||
| // The metadata contains all span configuration including name, type, labels, etc. | ||
| func RunInNewSpan[I, O any]( | ||
| ctx context.Context, | ||
| tstate *State, |
There was a problem hiding this comment.
Do we still need to take this in? Right now what's checked in main is just a global getter for the tracer provider, so it could just be called within this function, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics
(Will add thought metrics as a fast follow; they were added recently and don't want to keep exploding this PR)
Basic success flow
Error flow
Substep flow
Tool flow
(The Tool View looks slightly different because our tool loop inside the Generate() call is implemented slightly differently, that requires some more refactoring if we want the views to look exactly the same)