Skip to content

Conversation

kingsleyzhong
Copy link
Contributor

@kingsleyzhong kingsleyzhong commented Jul 18, 2025

Addressed issue: #3247

Copy link

google-cla bot commented Jul 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kingsleyzhong
Copy link
Contributor Author

Sorry, I pulled the wrong diff-file and didn't apply it properly.

@epuerta9
Copy link

epuerta9 commented Aug 4, 2025

@kingsleyzhong I just ran into this issue today

this is for tool call id issue issue right?

It seems to add the tool response to the tool call id

@kingsleyzhong
Copy link
Contributor Author

@kingsleyzhong I just ran into this issue today

this is for tool call id issue issue right?

It seems to add the tool response to the tool call id

Yes

@epuerta9
Copy link

epuerta9 commented Aug 5, 2025

@hugoaguirre just following up on this if this is okay to be merged

me and @kingsleyzhong both have this issue

@hugoaguirre
Copy link
Contributor

hugoaguirre commented Aug 5, 2025

Hi @epuerta9, I'll follow up with this today.

@kingsleyzhong, thanks for your contribution!

@epuerta9
Copy link

epuerta9 commented Aug 5, 2025

I appreciate it but I'll have to defer to @kingsleyzhong doing all the work for this!

@hugoaguirre hugoaguirre merged commit 46594d2 into firebase:main Aug 5, 2025
7 checks passed
@kingsleyzhong
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants