Skip to content

Conversation

@dpebot
Copy link
Collaborator

@dpebot dpebot commented Aug 26, 2021

Brought to you by your friendly Repository Gardener.

@google-cla google-cla bot added the cla: yes label Aug 26, 2021
@dpebot dpebot force-pushed the dpebot-repositorygardener-html branch from 2078884 to ccc98b9 Compare August 26, 2021 08:44
@jhuleatt
Copy link
Collaborator

We need to wait to merge this until we convert all samples in this repo to v9 or v9-compat

@kroikie
Copy link
Contributor

kroikie commented Aug 26, 2021

Ok in that case I would expect the tests to fail, any idea why the CI is passing?

<script src="/__/firebase/8.10.0/firebase-app.js"></script>
<script src="/__/firebase/8.10.0/firebase-auth.js"></script>
<script src="/__/firebase/8.10.0/firebase-database.js"></script>
<script src="/__/firebase/9.0.0/firebase-app.js"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<script src="/__/firebase/9.0.0/firebase-app.js"></script>
<script src="/__/firebase/9.0.0/firebase-app-compat.js"></script>

<script src="/__/firebase/9.0.0/firebase-app.js"></script>
<script src="/__/firebase/9.0.0/firebase-auth.js"></script>
<script src="/__/firebase/9.0.0/firebase-database.js"></script>
<script src="/__/firebase/init.js"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't need to change

@dpebot dpebot force-pushed the dpebot-repositorygardener-html branch 7 times, most recently from a8bde45 to 6349a95 Compare September 2, 2021 08:44
@dpebot dpebot force-pushed the dpebot-repositorygardener-html branch 8 times, most recently from 86bf740 to 0aa0bf1 Compare September 10, 2021 08:44
@dpebot dpebot force-pushed the dpebot-repositorygardener-html branch 7 times, most recently from 72320a6 to 9445145 Compare September 17, 2021 08:44
@dpebot dpebot force-pushed the dpebot-repositorygardener-html branch 2 times, most recently from 82e341a to 1592518 Compare September 19, 2021 08:44
@dpebot dpebot force-pushed the dpebot-repositorygardener-html branch from 3740be6 to bae742c Compare September 20, 2021 08:44
@dpebot dpebot force-pushed the dpebot-repositorygardener-html branch from 4dc5dd9 to 0546492 Compare September 21, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants