Skip to content

feat: updating not found exception to give more information #12813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: updating not found exception to give more information #12813

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ca8228
updating not found exception to give more information
bswhite1 May 21, 2024
677f07a
updating formatting
bswhite1 May 21, 2024
73aff40
Merge branch 'firebase:master' into not_found_exception_update
bswhite1 Jul 10, 2024
74af096
updating integration test to also look at the message portion of the …
bswhite1 Jul 10, 2024
b36512a
correcting analysis issue, and adding debugging
bswhite1 Jul 26, 2024
39ce6d2
Merge branch 'remoteMaster' of github.com:SwineTech-Inc/flutterfire i…
bswhite1 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/_flutterfire_internals/lib/src/exception.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,14 @@ FirebaseException platformExceptionToFirebaseException(

if (details != null) {
code = (details['code'] as String?) ?? code;
message = (details['message'] as String?) ?? message;

if ((code?.compareTo('not-found') == 0) && message.contains('NOT_FOUND:')) {
/// For not-found exceptions, return the Firestore provided reason and
/// document path rather than generic error message.
message = message.split('NOT_FOUND:').last.trim();
} else {
message = (details['message'] as String?) ?? message;
}
}

return FirebaseException(
Expand Down