[FDC] Detect all apps during `init dataconnect` #9026

fredzqm · 2025-08-21T21:02:47Z

From empty folder

From folder with existing apps

https://screencast.googleplex.com/cast/NTU0MDY1NzYzOTcxODkxMnw2YWEyNzNjMi1hYg

gemini-code-assist

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the application detection logic within the firebase init dataconnect command. It moves the platform detection utilities to a new appFinder module and introduces a more comprehensive detectApps function. This change aims to improve the initial setup experience by accurately identifying all applications in a project directory, ensuring appropriate SDK generation.

Highlights

Refactored app detection: Core logic for identifying application platforms (web, Android, iOS, Flutter) has been extracted from src/dataconnect/fileUtils.ts into a new dedicated module, src/dataconnect/appFinder.ts, promoting better organization and reusability.
Enhanced init dataconnect app discovery: The firebase init dataconnect command now utilizes a new detectApps function to identify all applications present in the current working directory, replacing the previous single-platform detection.
Streamlined SDK setup conditions: The condition for triggering SDK generation during init dataconnect has been updated to check for the presence of any detected web applications, making the process more precise.
Temporary suspension of framework-specific SDK detection: The automatic detection and enablement of framework-specific (e.g., React, Angular) JavaScript SDKs based on package.json analysis has been temporarily commented out in the SDK generation process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the application detection logic into a new appFinder.ts module, which is a good structural improvement. However, the changes introduce a couple of functional regressions. The automatic SDK setup now only triggers for web applications, whereas it previously triggered for any detected platform. Additionally, the logic to detect web frameworks like React and Angular has been commented out, removing the automatic configuration for their specific SDKs. These regressions should be addressed to ensure existing functionality is not lost.

src/init/features/dataconnect/index.ts

src/init/features/dataconnect/sdk.ts

- Fixed failing tests in `src/dataconnect/appFinder.spec.ts` by replacing `mock-fs` with `fs-extra` and rewriting the tests. - Added a new file `src/dataconnect/fileUtils.ts` and a corresponding test file `src/dataconnect/fileUtils.spec.ts` to improve test coverage.

maneesht · 2025-08-26T15:01:09Z

src/dataconnect/appFinder.spec.ts

+  });
+
+  it("should return WEB if package.json exists", async () => {
+    fs.outputFileSync(`${testDir}/package.json`, "{}");


I think down the line we should add helper functions here, but I'm fine with leaving this as-is until we increase the complexity of these tests.

😄 All of those tests are generated by Gemini Code Assist or Jules~

src/init/features/dataconnect/create_app.ts

src/init/features/dataconnect/index.ts

src/init/features/dataconnect/sdk.ts

maneesht · 2025-08-26T15:34:02Z

src/init/features/dataconnect/sdk.ts

    } else {
-      logSuccess(`Detected multiple app platforms in directory ${appDir}`);
-      // Can only setup one platform at a time, just ask the user
+      void trackGA4("dataconnect_init", {


When would fdcInfo be undefined?

If someone run firebase init dataconnect:sdk, it won't have fdcInfo set.

If someone run firebase init dataconnect or firebase init dataconnect dataconnect:init, the dataconnect feature is processed, so will set fdcInfo here.

The MCP firebase_init tool always set both.

That should definitely be added as a comment in this block

src/init/features/dataconnect/sdk.ts

maneesht · 2025-08-26T16:02:51Z

src/init/features/dataconnect/sdk.ts

-    logBullet(
-      "Run `npm i --save @angular/fire @tanstack-query-firebase/angular @tanstack/angular-query-experimental` to install angular sdk dependencies.\nVisit https://github.com/invertase/tanstack-query-firebase/tree/main/packages/angular for more information on how to set up Angular Generated SDKs for Firebase Data Connect",
-    );
+    case Platform.IOS: {


@aashishpatil-g to check these defaults

src/init/features/dataconnect/create_app.ts

maneesht · 2025-08-26T16:06:55Z

src/dataconnect/appFinder.ts

+  const packageJsonFiles = await detectFiles(dirPath, "package.json");
+  const pubSpecYamlFiles = await detectFiles(dirPath, "pubspec.yaml");
+  const srcMainFolders = await detectFiles(dirPath, "src/main/");
+  const xCodeProjects = await detectFiles(dirPath, "*.xcodeproj/");


I don't think this and line 45 are definitive in detecting whether the directory is for android/iOS

Tested this out with local Android & iOS app as well.

In http://shortn/_UksVreexKl, I defined the requirement of app.directory~ Will be sure need to document this clearly.

For now, this is still part of connector.yaml, we can refactor later.

src/init/features/dataconnect/create_app.ts

Co-authored-by: Maneesh Tewani <[email protected]>

src/init/index.ts

dconeybe · 2025-08-26T19:21:09Z

src/dataconnect/appFinder.ts

+/** Given a directory, determine the platform type */
+export async function getPlatformFromFolder(dirPath: string): Promise<Platform> {
+  const apps = await detectApps(dirPath);
+  const hasWeb = apps.some((app) => app.platform === Platform.WEB);


Consider, instead, creating a set with all discovered platform values. If the set's size is 0 then return NONE. If its size is 1 then return that platform. Otherwise return multiple. That will be more maintainable as well for when new platforms are added.

getPlatformFromFolder can go away soon.

Only kept it because management/apps.ts still use it.

"can go away soon" -> famous last words for code that will still exist in 10 years

github-project-automation bot added this to [Cloud] Extensions + Functions Aug 21, 2025

gemini-code-assist bot reviewed Aug 21, 2025

View reviewed changes

src/init/features/dataconnect/index.ts Outdated Show resolved Hide resolved

src/init/features/dataconnect/sdk.ts Outdated Show resolved Hide resolved

react template

0857121

fredzqm force-pushed the fz/apps branch from 25c6aa5 to 0857121 Compare August 22, 2025 21:00

fredzqm and others added 11 commits August 22, 2025 14:27

m

f6bd4dc

Merge remote-tracking branch 'origin/fix/dataconnect-tests' into fz/apps

d18e2c7

commit

bd14600

tests

8fb692e

tests

b6d40df

merge

8993523

tests

32b2ddf

m

95b2e48

changelog

761ec89

m

4a5b148

fredzqm requested a review from maneesht August 22, 2025 22:54

fredzqm added 12 commits August 22, 2025 16:00

vite react template commented out

f46a001

m

91b8b30

pick between react & next

73aa6a0

metrics

cf69843

metric

4d2f2eb

m

3eb8b30

tests

ee46a5d

m

cd15f7b

m

851438c

Merge branch 'master' into fz/apps

1e0ebf1

Merge remote-tracking branch 'origin/master' into fz/apps

23fa07d

only trust ENV_VAR when envPlatform is also set

0173bde

maneesht reviewed Aug 26, 2025

View reviewed changes

src/init/features/dataconnect/create_app.ts Outdated Show resolved Hide resolved

maneesht reviewed Aug 26, 2025

View reviewed changes

src/init/features/dataconnect/index.ts Outdated Show resolved Hide resolved

maneesht reviewed Aug 26, 2025

View reviewed changes

src/init/features/dataconnect/sdk.ts Show resolved Hide resolved

maneesht reviewed Aug 26, 2025

View reviewed changes

src/init/features/dataconnect/sdk.ts Outdated Show resolved Hide resolved

fredzqm added 5 commits August 26, 2025 08:17

Merge branch 'master' into fz/apps

8caa946

Merge remote-tracking branch 'origin/fz/apps' into fz/apps

132cc15

comments

06d5882

warning log

d752ace

m

0ff4595

maneesht reviewed Aug 26, 2025

View reviewed changes

fredzqm and others added 4 commits August 26, 2025 10:38

Update src/init/features/dataconnect/sdk.ts

cef0edd

Co-authored-by: Maneesh Tewani <[email protected]>

m

fbbc229

Merge remote-tracking branch 'origin/fz/apps' into fz/apps

4d91fa7

feedbacks

38aa32c

maneesht reviewed Aug 26, 2025

View reviewed changes

src/init/index.ts Outdated Show resolved Hide resolved

remove

bded9d6

dconeybe reviewed Aug 26, 2025

View reviewed changes

[FDC] Detect all apps during init dataconnect #9026

Are you sure you want to change the base?

[FDC] Detect all apps during init dataconnect #9026

Uh oh!

Conversation

fredzqm commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From empty folder

From folder with existing apps

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fredzqm Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

[FDC] Detect all apps during `init dataconnect` #9026

[FDC] Detect all apps during `init dataconnect` #9026

fredzqm commented Aug 21, 2025 •

edited

Loading

fredzqm Aug 26, 2025 •

edited

Loading