-
Notifications
You must be signed in to change notification settings - Fork 1k
feature: add param attempt deadline for cloud scheduler #9007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Skyfury2651, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for the attemptDeadline
parameter within Cloud Scheduler jobs, enabling users to specify a maximum duration for a job attempt. This enhancement provides finer control over job execution and retry behavior. The changes involve updating relevant TypeScript interfaces, modifying the build and discovery processes to handle this new parameter, and integrating it into the Cloud Scheduler API calls to ensure proper propagation and application of the deadline.
Highlights
- Interface Updates: The
ScheduleTrigger
interface insrc/deploy/functions/backend.ts
andsrc/deploy/functions/build.ts
has been extended to include an optionalattemptDeadline
property, allowing for the definition of a maximum duration for job attempts. - Configuration Resolution and Validation: The
discoverTrigger
function insrc/deploy/functions/build.ts
and the parsing logic insrc/deploy/functions/runtimes/discovery/v1alpha1.ts
have been updated to correctly resolve, validate, and parse the newattemptDeadline
parameter from endpoint configurations. - Cloud Scheduler API Integration: The
HttpTarget
interface insrc/gcp/cloudscheduler.ts
now includesattemptDeadline
, and thejobFromEndpoint
function has been modified to propagate this value to the Cloud Scheduler job configuration when creating or updating jobs.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the attemptDeadline
parameter for Cloud Scheduler jobs. The changes look good and correctly propagate the new parameter through different layers of the application. I have one suggestion to improve code conciseness and consistency.
if (endpoint.scheduleTrigger.timeZone !== undefined) { | ||
bkSchedule.timeZone = r.resolveString(endpoint.scheduleTrigger.timeZone); | ||
} | ||
if (endpoint.scheduleTrigger.attemptDeadline !== undefined) { | ||
bkSchedule.attemptDeadline = r.resolveString(endpoint.scheduleTrigger.attemptDeadline); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Added new params attempt_exceed for cloud scheduler. ( Currently google api have already supported this params )
https://cloud.google.com/scheduler/docs/reference/rest/v1beta1/projects.locations.jobs#Job
Sample Commands