feat: Add unit tests for getDefaultHostingSite and getProjectNumber

src/getDefaultHostingSite.spec.ts

@@ -0,0 +1,78 @@
+import { expect } from "chai";
+import * as sinon from "sinon";
+
+import { getDefaultHostingSite, errNoDefaultSite } from "./getDefaultHostingSite";
+import * as projectUtils from "./projectUtils";
+import * as projects from "./management/projects";
+import * as hostingApi from "./hosting/api";
+import { SiteType } from "./hosting/api";
+
+const PROJECT_ID = "test-project-id";
+
+describe("getDefaultHostingSite", () => {
+  let sandbox: sinon.SinonSandbox;
+  let getFirebaseProjectStub: sinon.SinonStub;
+  let listSitesStub: sinon.SinonStub;
+
+  beforeEach(() => {
+    sandbox = sinon.createSandbox();
+    sandbox.stub(projectUtils, "needProjectId").returns(PROJECT_ID);
+    getFirebaseProjectStub = sandbox.stub(projects, "getFirebaseProject");
+    listSitesStub = sandbox.stub(hostingApi, "listSites");
+  });
+
+  afterEach(() => {
+    sandbox.restore();
+  });
+
+  it("should return the default hosting site from project resources", async () => {
+    const defaultSite = "my-default-site";
+    getFirebaseProjectStub.resolves({
+      resources: { hostingSite: defaultSite },
+    });
+
+    const site = await getDefaultHostingSite({ projectId: PROJECT_ID });
+
+    expect(site).to.equal(defaultSite);
+    expect(getFirebaseProjectStub).to.have.been.calledWith(PROJECT_ID);
+    expect(listSitesStub).to.not.have.been.called;
+  });
+
+  it("should return the default hosting site from listSites if not in project resources", async () => {
+    const defaultSite = "another-default-site";
+    getFirebaseProjectStub.resolves({ resources: {} });
+    listSitesStub.resolves([
+      { name: `projects/${PROJECT_ID}/sites/other-site`, type: SiteType.USER_SITE },
+      { name: `projects/${PROJECT_ID}/sites/${defaultSite}`, type: SiteType.DEFAULT_SITE },
+    ]);
+
+    const site = await getDefaultHostingSite({ projectId: PROJECT_ID });
+
+    expect(site).to.equal(defaultSite);
+    expect(getFirebaseProjectStub).to.have.been.calledWith(PROJECT_ID);
+    expect(listSitesStub).to.have.been.calledWith(PROJECT_ID);
+  });
+
+  it("should throw an error if no default site is found", async () => {
+    getFirebaseProjectStub.resolves({ resources: {} });
+    listSitesStub.resolves([
+      { name: `projects/${PROJECT_ID}/sites/other-site`, type: SiteType.USER_SITE },
+    ]);
+
+    await expect(getDefaultHostingSite({ projectId: PROJECT_ID })).to.be.rejectedWith(
+      errNoDefaultSite,
+    );
+
+    expect(getFirebaseProjectStub).to.have.been.calledWith(PROJECT_ID);
+    expect(listSitesStub).to.have.been.calledWith(PROJECT_ID);
+  });
+
+  it("should throw an error if listSites returns no sites", async () => {
+    getFirebaseProjectStub.resolves({ resources: {} });
+    listSitesStub.resolves([]);
+
+    await expect(getDefaultHostingSite({ projectId: PROJECT_ID })).to.be.rejectedWith(
+      errNoDefaultSite,
+    );
+  });
+});

src/getProjectNumber.spec.ts

@@ -0,0 +1,46 @@
+import { expect } from "chai";
+import * as sinon from "sinon";
+
+import { getProjectNumber } from "./getProjectNumber";
+import * as projectUtils from "./projectUtils";
+import * as projects from "./management/projects";
+
+const PROJECT_ID = "test-project-id";
+const PROJECT_NUMBER = "123456789";
+
+describe("getProjectNumber", () => {
+  let sandbox: sinon.SinonSandbox;
+  let needProjectIdStub: sinon.SinonStub;
+  let getProjectStub: sinon.SinonStub;
+
+  beforeEach(() => {
+    sandbox = sinon.createSandbox();
+    needProjectIdStub = sandbox.stub(projectUtils, "needProjectId").returns(PROJECT_ID);
+    getProjectStub = sandbox.stub(projects, "getProject");
+  });
+
+  afterEach(() => {
+    sandbox.restore();
+  });
+
+  it("should return project number from options if it exists", async () => {
+    const options = { projectNumber: PROJECT_NUMBER };
+    const projectNumber = await getProjectNumber(options);
+
+    expect(projectNumber).to.equal(PROJECT_NUMBER);
+    expect(needProjectIdStub).to.not.have.been.called;
+    expect(getProjectStub).to.not.have.been.called;
+  });
+
+  it("should fetch project number if not in options", async () => {
+    const options: any = { projectId: PROJECT_ID };
+    getProjectStub.resolves({ projectNumber: PROJECT_NUMBER });
+
+    const projectNumber = await getProjectNumber(options);
+
+    expect(projectNumber).to.equal(PROJECT_NUMBER);
+    expect(needProjectIdStub).to.have.been.calledWith(options);
+    expect(getProjectStub).to.have.been.calledWith(PROJECT_ID);
+    expect(options.projectNumber).to.equal(PROJECT_NUMBER);
+  });
+});