Skip to content

Update min node version to 18, add 20 to supported versions & CI #6447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Update min node version to 18, add 20 to supported versions & CI #6447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc5d3c1
Update min node version to 18, add 20 to supported versions & CI
joehan Oct 13, 2023
9f157cb
Fix broken unit test
joehan Oct 13, 2023
c17c51a
Bump dockefiles to Node 20 as well
joehan Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/node-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:
strategy:
matrix:
node-version:
- "18"
- "20"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v3
Expand All @@ -44,10 +44,10 @@ jobs:
strategy:
matrix:
node-version:
- "16"
- "18"
- "20"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
Expand All @@ -59,7 +59,7 @@ jobs:
- run: npm test -- -- --forbid-only

- uses: codecov/codecov-action@v3
if: matrix.node-version == '16'
if: matrix.node-version == '20'

integration:
needs: unit
Expand All @@ -79,7 +79,7 @@ jobs:
fail-fast: false
matrix:
node-version:
- "18"
- "20"
script:
- npm run test:client-integration
- npm run test:emulator
Expand All @@ -94,7 +94,7 @@ jobs:
- npm run test:triggers-end-to-end
- npm run test:triggers-end-to-end:inspect
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
Expand Down Expand Up @@ -135,7 +135,7 @@ jobs:
fail-fast: false
matrix:
node-version:
- "18"
- "20"
script:
- npm run test:hosting
# - npm run test:hosting-rewrites # Long-running test that might conflict across test runs. Run this manually.
Expand All @@ -155,7 +155,7 @@ jobs:
java-version: 17
distribution: temurin

- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
Expand Down Expand Up @@ -184,10 +184,10 @@ jobs:
strategy:
matrix:
node-version:
- "18"
- "20"

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand All @@ -203,10 +203,10 @@ jobs:
strategy:
matrix:
node-version:
- "18"
- "20"

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand All @@ -222,10 +222,10 @@ jobs:
strategy:
matrix:
node-version:
- "18"
- "20"

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
],
"preferGlobal": true,
"engines": {
"node": ">=16.13.0 || >=18.0.0"
"node": ">=18.0.0 || >=20.0.0"
},
"author": "Firebase (https://firebase.google.com/)",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion scripts/build/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18
FROM node:20

# Install dependencies
RUN apt-get update && \
Expand Down
2 changes: 1 addition & 1 deletion scripts/emulator-tests/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"firebase-functions": "^4.0.0"
},
"engines": {
"node": "16"
"node": "20"
}
}
2 changes: 1 addition & 1 deletion scripts/examples/hosting/update-single-file/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"test": "echo \"Error: no test specified\" && exit 1"
},
"engines": {
"node": ">=18.0.0"
"node": ">=20.0.0"
},
"author": "",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion scripts/extensions-emulator-tests/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Cloud Functions for Firebase",
"scripts": {},
"engines": {
"node": "14"
"node": "20"
},
"dependencies": {
"firebase-admin": "^9.3.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/firepit-builder/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18
FROM node:20

# Install dependencies
RUN apt-get update && \
Expand Down
2 changes: 1 addition & 1 deletion scripts/functions-deploy-tests/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"firebase-functions": "^4.1.0"
},
"engines": {
"node": "18"
"node": "20"
},
"private": true
}
2 changes: 1 addition & 1 deletion scripts/functions-discover-tests/fixtures/bundled/dist/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"name": "dist",
"version": "0.0.1",
"engines": {
"node": "16"
"node": "20"
}
}
2 changes: 1 addition & 1 deletion scripts/functions-discover-tests/fixtures/bundled/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"firebase-functions": "^4.1.1"
},
"engines": {
"node": "16"
"node": "20"
}
}
2 changes: 1 addition & 1 deletion scripts/functions-discover-tests/fixtures/codebases/v1/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"firebase-functions": "^4.0.0"
},
"engines": {
"node": "18"
"node": "20"
}
}
2 changes: 1 addition & 1 deletion scripts/functions-discover-tests/fixtures/codebases/v2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"firebase-functions": "^4.0.0"
},
"engines": {
"node": "18"
"node": "20"
}
}
2 changes: 1 addition & 1 deletion scripts/functions-discover-tests/fixtures/esm/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"firebase-functions": "^4.0.0"
},
"engines": {
"node": "18"
"node": "20"
}
}
2 changes: 1 addition & 1 deletion scripts/functions-discover-tests/fixtures/pnpm/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"firebase-functions": "^4.0.0"
},
"engines": {
"node": "18"
"node": "20"
}
}
2 changes: 1 addition & 1 deletion scripts/functions-discover-tests/fixtures/simple/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"firebase-functions": "^4.0.0"
},
"engines": {
"node": "18"
"node": "20"
}
}
2 changes: 1 addition & 1 deletion scripts/functions-discover-tests/fixtures/yarn-workspaces/packages/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"@firebase/a-test-pkg": "0.0.1"
},
"engines": {
"node": "18"
"node": "20"
},
"private": true
}
2 changes: 1 addition & 1 deletion scripts/test-project/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"firebase-functions": "^3.2.0"
},
"engines": {
"node": "12"
"node": "20"
}
}
2 changes: 1 addition & 1 deletion scripts/triggers-end-to-end-tests/triggers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Cloud Functions for Firebase",
"scripts": {},
"engines": {
"node": "18"
"node": "20"
},
"dependencies": {
"@firebase/database-compat": "0.1.2",
Expand Down
2 changes: 1 addition & 1 deletion scripts/triggers-end-to-end-tests/v1/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Cloud Functions for Firebase",
"scripts": {},
"engines": {
"node": "18"
"node": "20"
},
"dependencies": {
"@firebase/database-compat": "0.1.2",
Expand Down
2 changes: 1 addition & 1 deletion scripts/triggers-end-to-end-tests/v2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Cloud Functions for Firebase",
"scripts": {},
"engines": {
"node": "18"
"node": "20"
},
"dependencies": {
"firebase-admin": "^11.0.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/webframeworks-deploy-tests/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"logs": "firebase functions:log"
},
"engines": {
"node": "18"
"node": "20"
},
"main": "index.js",
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion src/test/apiv2.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ describe("apiv2", () => {
method: "GET",
path: "/path/to/foo",
});
await expect(r).to.eventually.be.rejectedWith(FirebaseError, /Unexpected token.+JSON/);
await expect(r).to.eventually.be.rejectedWith(FirebaseError, /Unable to parse JSON/);
expect(nock.isDone()).to.be.true;
});

Expand Down