Skip to content

Install script should abort on network failure #8931

@MeinAccount

Description

@MeinAccount

[REQUIRED] Environment info

Platform: Ubuntu 20.04

[REQUIRED] Test case

Running the install script on a mobile network. When the curl failed, the install script continued and asked for the sudo password. After rejecting the sudo-promt (Ctrl+C) the script also continued.

> curl -sL https://firebase.tools | bash
-- Checking for existing firebase-tools...
-- Checking your machine type...
-- Downloading binary from https://firebase.tools/bin/linux/latest
######################################################################## 100.0%##O=#  #                          
##################################                                        47.7%curl: (18) transfer closed with 126580227 bytes remaining to read

[sudo] password for ******: 
[sudo] password for ******: 
-- Setting permissions on binary... /usr/local/bin/firebase
[sudo] password for ******: 
bash: line 279: /usr/local/bin/firebase: No such file or directory
Something went wrong, firebase has not been installed.
Please file a bug with your system information on Github.
https://github.com/firebase/firebase-tools/
-- All done!

[REQUIRED] Expected behavior

The script should abort on errors

[REQUIRED] Actual behavior

The script continues through all errors

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions