-
Notifications
You must be signed in to change notification settings - Fork 964
fix(ai): keep window-specific code out of Node bundle #9225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlarocque
approved these changes
Aug 26, 2025
🦋 Changeset detectedLatest commit: afe62fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (86,235 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping all
window
specific code except for checkingtypeof window
out of the Node bundle.Have
index.ts
(browser entry point) pass achromeAdapterFactory
to theAIService
constructor.index.node.ts
doesn't pass this so the Node bundle will not have any code referring to window.LanguageModel nor will it even have the entire ChromeAdapterImpl class.getGenerativeModel()
will only callAIService.chromeAdapterFactory
if it finds it. I screwed up casing initially on window.LanguageModel so it is important to test thatchromeAdapterFactory
actually instantiates the class right.Also
-browser.test.ts
, which is justchrome-adapter-brower.test.ts
but may be more.BackendName
typings fix from feat(ai): add support for the Live API #9224