Skip to content

Truncate long element names for OOB core web vital metrics #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

Truncate long element names for OOB core web vital metrics #9178

merged 1 commit into from
Jul 22, 2025

Conversation

raymondlam
Copy link
Member

@raymondlam raymondlam commented Jul 21, 2025 •
edited
Loading

Fixes a bug where the out-of-the-box core web vital metrics would throw an error when the target element name exceeds the max length of a custom attribute value (100 characters).

Fixes #9136

@raymondlam
Fixes a bug where the out-of-the-box core web vital metrics would thr…
1117571 
…ow an error when the target element name exceeds the max length of a custom attribute value.
@raymondlam raymondlam requested review from a team and visumickey as code owners July 21, 2025 22:45
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2025

🦋 Changeset detected

Latest commit: 1117571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/performance Patch
firebase Patch
@firebase/performance-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/performance

    TypeBase (56fbe52)Merge (105d551)Diff
    browser31.1 kB31.2 kB+169 B (+0.5%)
    main31.5 kB31.7 kB+169 B (+0.5%)
    module31.1 kB31.2 kB+169 B (+0.5%)

  • bundle

    TypeBase (56fbe52)Merge (105d551)Diff
    performance (trace)62.0 kB62.1 kB+96 B (+0.2%)

  • firebase

    TypeBase (56fbe52)Merge (105d551)Diff
    firebase-compat.js800 kB800 kB+90 B (+0.0%)
    firebase-performance-compat.js40.2 kB40.3 kB+90 B (+0.2%)
    firebase-performance-standalone-compat.js105 kB105 kB+90 B (+0.1%)
    firebase-performance.js45.5 kB45.6 kB+90 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pGptFRutfl.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/performance

    • getPerformance

      Size

      TypeBase (56fbe52)Merge (105d551)Diff
      size19.1 kB19.2 kB+94 B (+0.5%)
      size-with-ext-deps61.8 kB61.9 kB+96 B (+0.2%)

    • initializePerformance

      Size

      TypeBase (56fbe52)Merge (105d551)Diff
      size19.3 kB19.3 kB+94 B (+0.5%)
      size-with-ext-deps55.4 kB55.5 kB+96 B (+0.2%)

    • trace

      Size

      TypeBase (56fbe52)Merge (105d551)Diff
      size19.0 kB19.1 kB+94 B (+0.5%)
      size-with-ext-deps54.8 kB54.9 kB+96 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JjLgkWheVU.html

visumickey
visumickey approved these changes Jul 22, 2025
View reviewed changes
@raymondlam raymondlam merged commit a4897a6 into main Jul 22, 2025
43 of 44 checks passed
@raymondlam raymondlam deleted the raymondlam_fixWebVitalAttributeValue branch July 22, 2025 18:53
@google-oss-bot google-oss-bot mentioned this pull request Aug 6, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FirebaseError: Performance (performance/invalid attribute value)
4 participants
@raymondlam @google-oss-bot @visumickey @hsubox76