fix(firestore): fix empty message reject inside transaction body #9177

cherylEnkidu · 2025-07-21T18:59:46Z

Discussion
This pull request resolves a bug where a Firestore transaction would hang indefinitely if an error without a message property was thrown within the transaction's body.

The root cause of this issue was an incorrect assumption in the SDK that an error object would always contain a message. This change corrects the logic to ensure that the SDK can gracefully handle errors that lack a message.

Fixes #9147

Testing
Verify in integration test

changeset-bot · 2025-07-21T18:59:50Z

🦋 Changeset detected

Latest commit: 56ca0e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2025-07-21T19:09:28Z

Size Report ¹

Affected Products

@firebase/ai
Type Base (56fbe52) Merge (75f6f28) Diff
browser 39.4 kB 45.8 kB +6.47 kB (+16.4%)
main 42.4 kB 48.9 kB +6.54 kB (+15.4%)
module 39.4 kB 45.8 kB +6.47 kB (+16.4%)
@firebase/app-check
Type Base (56fbe52) Merge (75f6f28) Diff
browser 26.3 kB 26.4 kB +28 B (+0.1%)
main 27.3 kB 27.3 kB +28 B (+0.1%)
module 26.3 kB 26.4 kB +28 B (+0.1%)
@firebase/firestore
Type Base (56fbe52) Merge (75f6f28) Diff
browser 391 kB 391 kB +1 B (+0.0%)
main 611 kB 611 kB +1 B (+0.0%)
module 391 kB 391 kB +1 B (+0.0%)
react-native 392 kB 392 kB +1 B (+0.0%)
@firebase/firestore-lite
Type Base (56fbe52) Merge (75f6f28) Diff
browser 115 kB 115 kB +1 B (+0.0%)
main 158 kB 158 kB +1 B (+0.0%)
module 115 kB 115 kB +1 B (+0.0%)
react-native 116 kB 116 kB +1 B (+0.0%)
@firebase/functions
Type Base (56fbe52) Merge (75f6f28) Diff
browser 13.9 kB 14.2 kB +297 B (+2.1%)
main 14.4 kB 14.7 kB +302 B (+2.1%)
module 13.9 kB 14.2 kB +297 B (+2.1%)
@firebase/performance
Type Base (56fbe52) Merge (75f6f28) Diff
browser 31.1 kB 31.2 kB +169 B (+0.5%)
main 31.5 kB 31.7 kB +169 B (+0.5%)
module 31.1 kB 31.2 kB +169 B (+0.5%)

`bundle`

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
app-check (CustomProvider)	37.2 kB	37.2 kB	+10 B (+0.0%)
app-check (ReCaptchaEnterpriseProvider)	39.6 kB	39.6 kB	+10 B (+0.0%)
app-check (ReCaptchaV3Provider)	39.5 kB	39.6 kB	+10 B (+0.0%)
firestore (Transaction)	224 kB	224 kB	+1 B (+0.0%)
firestore-lite (Transaction)	107 kB	107 kB	+1 B (+0.0%)
functions (call)	38.6 kB	38.7 kB	+132 B (+0.3%)
performance (trace)	62.0 kB	62.1 kB	+96 B (+0.2%)

`firebase`

12 size changes

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
firebase-ai.js	31.1 kB	35.8 kB	+4.70 kB (+15.1%)
firebase-app-check-compat.js	22.8 kB	22.8 kB	+6 B (+0.0%)
firebase-app-check.js	25.0 kB	25.0 kB	+10 B (+0.0%)
firebase-compat.js	800 kB	800 kB	+227 B (+0.0%)
firebase-firestore-compat.js	349 kB	349 kB	+1 B (+0.0%)
firebase-firestore-lite.js	138 kB	138 kB	+1 B (+0.0%)
firebase-firestore.js	455 kB	455 kB	+1 B (+0.0%)
firebase-functions-compat.js	14.7 kB	14.8 kB	+126 B (+0.9%)
firebase-functions.js	19.4 kB	19.5 kB	+182 B (+0.9%)
firebase-performance-compat.js	40.2 kB	40.3 kB	+90 B (+0.2%)
firebase-performance-standalone-compat.js	105 kB	105 kB	+90 B (+0.1%)
firebase-performance.js	45.5 kB	45.6 kB	+90 B (+0.2%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/cygTr940YB.html

google-oss-bot · 2025-07-21T19:21:37Z

Size Analysis Report ¹

Affected Products

`@firebase/ai`

`AIError`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.40 kB	2.55 kB	+154 B (+6.4%)
size-with-ext-deps	19.9 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Task name version	+ Availability

`AIErrorCode`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.40 kB	2.55 kB	+154 B (+6.4%)
size-with-ext-deps	19.9 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Task name version	+ Availability

`AIModel`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	3.94 kB	4.09 kB	+154 B (+3.9%)
size-with-ext-deps	21.5 kB	21.7 kB	+157 B (+0.7%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Task name version	+ Availability

`AnyOfSchema`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	4.72 kB	4.87 kB	+154 B (+3.3%)
size-with-ext-deps	22.3 kB	22.4 kB	+157 B (+0.7%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION SchemaType Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION SchemaType Task name version	+ Availability

`ArraySchema`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	4.72 kB	4.87 kB	+154 B (+3.3%)
size-with-ext-deps	22.3 kB	22.4 kB	+157 B (+0.7%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION SchemaType Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION SchemaType Task name version	+ Availability

`Backend`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.40 kB	2.55 kB	+154 B (+6.4%)
size-with-ext-deps	19.9 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Task name version	+ Availability

`BackendType`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.40 kB	2.55 kB	+154 B (+6.4%)
size-with-ext-deps	19.9 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Task name version	+ Availability

`BlockReason`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.50 kB	2.66 kB	+154 B (+6.2%)
size-with-ext-deps	20.0 kB	20.2 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType BlockReason DEFAULT_LOCATION Task name version	AIErrorCode AI_TYPE Availability BackendType BlockReason DEFAULT_LOCATION Task name version	+ Availability

`BooleanSchema`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	4.72 kB	4.88 kB	+154 B (+3.3%)
size-with-ext-deps	22.3 kB	22.4 kB	+157 B (+0.7%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION SchemaType Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION SchemaType Task name version	+ Availability

`ChatSession`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	16.9 kB	17.4 kB	+449 B (+2.7%)
size-with-ext-deps	34.6 kB	35.1 kB	+448 B (+1.3%)

Dependency

Type Base (56fbe52) Merge (75f6f28) Diff

functions

28 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
createEnhancedContentResponse
decodeInstanceIdentifier
formatBlockErrorMessage
formatNewContent
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getInlineDataParts
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
mapGenerateContentCandidates
mapGenerateContentRequest
mapGenerateContentResponse
mapPromptFeedback
processGenerateContentResponse
processStream
registerAI
validateChatHistory

30 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
createEnhancedContentResponse
decodeInstanceIdentifier
formatBlockErrorMessage
formatNewContent
generateContent
generateContentOnCloud
generateContentStream
generateContentStreamOnCloud
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getInlineDataParts
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
mapGenerateContentCandidates
mapGenerateContentRequest
mapGenerateContentResponse
mapPromptFeedback
processGenerateContentResponse
processStream
registerAI
validateChatHistory

+ generateContentOnCloud
+ generateContentStreamOnCloud

variables

22 dependencies

AIErrorCode
AI_TYPE
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
FinishReason
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
badFinishReasons
logger
name
responseLineRE
version

23 dependencies

AIErrorCode
AI_TYPE
Availability
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
FinishReason
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
badFinishReasons
logger
name
responseLineRE
version

+ Availability

`FinishReason`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.65 kB	2.80 kB	+154 B (+5.8%)
size-with-ext-deps	20.2 kB	20.3 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION FinishReason Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION FinishReason Task name version	+ Availability

`FunctionCallingMode`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.45 kB	2.61 kB	+154 B (+6.3%)
size-with-ext-deps	20.0 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION FunctionCallingMode Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION FunctionCallingMode Task name version	+ Availability

`GenerativeModel`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	20.3 kB	20.9 kB	+664 B (+3.3%)
size-with-ext-deps	38.0 kB	38.7 kB	+663 B (+1.7%)

Dependency

Type Base (56fbe52) Merge (75f6f28) Diff

functions

32 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
createEnhancedContentResponse
decodeInstanceIdentifier
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getInlineDataParts
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
mapCountTokensRequest
mapGenerateContentCandidates
mapGenerateContentRequest
mapGenerateContentResponse
mapPromptFeedback
processGenerateContentResponse
processStream
registerAI
validateChatHistory

35 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
countTokensOnCloud
createEnhancedContentResponse
decodeInstanceIdentifier
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateContentStreamOnCloud
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getInlineDataParts
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
mapCountTokensRequest
mapGenerateContentCandidates
mapGenerateContentRequest
mapGenerateContentResponse
mapPromptFeedback
processGenerateContentResponse
processStream
registerAI
validateChatHistory

+ countTokensOnCloud
+ generateContentOnCloud
+ generateContentStreamOnCloud

variables

22 dependencies

AIErrorCode
AI_TYPE
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
FinishReason
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
badFinishReasons
logger
name
responseLineRE
version

23 dependencies

AIErrorCode
AI_TYPE
Availability
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
FinishReason
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
badFinishReasons
logger
name
responseLineRE
version

+ Availability

`GoogleAIBackend`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.40 kB	2.56 kB	+154 B (+6.4%)
size-with-ext-deps	19.9 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Task name version	+ Availability

`HarmBlockMethod`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.46 kB	2.61 kB	+154 B (+6.3%)
size-with-ext-deps	20.0 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION HarmBlockMethod Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION HarmBlockMethod Task name version	+ Availability

`HarmBlockThreshold`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.58 kB	2.73 kB	+154 B (+6.0%)
size-with-ext-deps	20.1 kB	20.3 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION HarmBlockThreshold Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION HarmBlockThreshold Task name version	+ Availability

`HarmCategory`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.65 kB	2.80 kB	+154 B (+5.8%)
size-with-ext-deps	20.2 kB	20.3 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION HarmCategory Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION HarmCategory Task name version	+ Availability

`HarmProbability`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.48 kB	2.63 kB	+154 B (+6.2%)
size-with-ext-deps	20.0 kB	20.2 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION HarmProbability Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION HarmProbability Task name version	+ Availability

`HarmSeverity`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.64 kB	2.79 kB	+154 B (+5.8%)
size-with-ext-deps	20.2 kB	20.3 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION HarmSeverity Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION HarmSeverity Task name version	+ Availability

`ImagenAspectRatio`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.51 kB	2.67 kB	+154 B (+6.1%)
size-with-ext-deps	20.0 kB	20.2 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION ImagenAspectRatio Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION ImagenAspectRatio Task name version	+ Availability

`ImagenImageFormat`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.69 kB	2.84 kB	+154 B (+5.7%)
size-with-ext-deps	20.2 kB	20.4 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Task logger name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Task logger name version	+ Availability

`ImagenModel`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	8.84 kB	8.99 kB	+154 B (+1.7%)
size-with-ext-deps	26.5 kB	26.6 kB	+157 B (+0.6%)

Dependency

Type Base (56fbe52) Merge (75f6f28) Diff

variables

13 dependencies

AIErrorCode
AI_TYPE
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
LANGUAGE_TAG
PACKAGE_VERSION
Task
logger
name
version

14 dependencies

AIErrorCode
AI_TYPE
Availability
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
LANGUAGE_TAG
PACKAGE_VERSION
Task
logger
name
version

+ Availability

`ImagenPersonFilterLevel`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.49 kB	2.65 kB	+154 B (+6.2%)
size-with-ext-deps	20.0 kB	20.2 kB	+157 B (+0.8%)

Dependency

Type Base (56fbe52) Merge (75f6f28) Diff

variables

AIErrorCode
AI_TYPE
BackendType
DEFAULT_LOCATION
ImagenPersonFilterLevel
Task
name
version

AIErrorCode
AI_TYPE
Availability
BackendType
DEFAULT_LOCATION
ImagenPersonFilterLevel
Task
name
version

+ Availability

`ImagenSafetyFilterLevel`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.57 kB	2.72 kB	+154 B (+6.0%)
size-with-ext-deps	20.1 kB	20.3 kB	+157 B (+0.8%)

Dependency

Type Base (56fbe52) Merge (75f6f28) Diff

variables

AIErrorCode
AI_TYPE
BackendType
DEFAULT_LOCATION
ImagenSafetyFilterLevel
Task
name
version

AIErrorCode
AI_TYPE
Availability
BackendType
DEFAULT_LOCATION
ImagenSafetyFilterLevel
Task
name
version

+ Availability

`InferenceMode`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	?	2.66 kB	? (?)
size-with-ext-deps	?	20.2 kB	? (?)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
functions	?	decodeInstanceIdentifier registerAI	?
classes	?	AIError AIService Backend GoogleAIBackend VertexAIBackend	?
variables	?	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION InferenceMode Task name version	?
enums	?		?

External Dependency

Module	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
`@firebase/app`	?	_registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	FirebaseError	?

`IntegerSchema`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	4.72 kB	4.88 kB	+154 B (+3.3%)
size-with-ext-deps	22.3 kB	22.4 kB	+157 B (+0.7%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION SchemaType Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION SchemaType Task name version	+ Availability

`Modality`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.53 kB	2.68 kB	+154 B (+6.1%)
size-with-ext-deps	20.1 kB	20.2 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Modality Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Modality Task name version	+ Availability

`NumberSchema`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	4.72 kB	4.88 kB	+154 B (+3.3%)
size-with-ext-deps	22.3 kB	22.4 kB	+157 B (+0.7%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION SchemaType Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION SchemaType Task name version	+ Availability

`ObjectSchema`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	4.72 kB	4.88 kB	+154 B (+3.3%)
size-with-ext-deps	22.3 kB	22.4 kB	+157 B (+0.7%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION SchemaType Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION SchemaType Task name version	+ Availability

`POSSIBLE_ROLES`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.45 kB	2.60 kB	+154 B (+6.3%)
size-with-ext-deps	20.0 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION POSSIBLE_ROLES Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION POSSIBLE_ROLES Task name version	+ Availability

`ResponseModality`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.44 kB	2.60 kB	+154 B (+6.3%)
size-with-ext-deps	20.0 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION ResponseModality Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION ResponseModality Task name version	+ Availability

`Schema`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	4.72 kB	4.87 kB	+154 B (+3.3%)
size-with-ext-deps	22.3 kB	22.4 kB	+157 B (+0.7%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION SchemaType Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION SchemaType Task name version	+ Availability

`SchemaType`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.51 kB	2.66 kB	+154 B (+6.1%)
size-with-ext-deps	20.0 kB	20.2 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION SchemaType Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION SchemaType Task name version	+ Availability

`StringSchema`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	4.72 kB	4.88 kB	+154 B (+3.3%)
size-with-ext-deps	22.3 kB	22.4 kB	+157 B (+0.7%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION SchemaType Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION SchemaType Task name version	+ Availability

`VertexAIBackend`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.40 kB	2.56 kB	+154 B (+6.4%)
size-with-ext-deps	19.9 kB	20.1 kB	+157 B (+0.8%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Task name version	+ Availability

`getAI`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	2.76 kB	2.91 kB	+154 B (+5.6%)
size-with-ext-deps	27.4 kB	27.6 kB	+157 B (+0.6%)

Dependency

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
variables	AIErrorCode AI_TYPE BackendType DEFAULT_LOCATION Task name version	AIErrorCode AI_TYPE Availability BackendType DEFAULT_LOCATION Task name version	+ Availability

`getGenerativeModel`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	20.4 kB	25.1 kB	+4.65 kB (+22.7%)
size-with-ext-deps	38.2 kB	42.9 kB	+4.66 kB (+12.2%)

Dependency

Type Base (56fbe52) Merge (75f6f28) Diff

functions

33 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
createEnhancedContentResponse
decodeInstanceIdentifier
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getGenerativeModel
getHeaders
getInlineDataParts
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
mapCountTokensRequest
mapGenerateContentCandidates
mapGenerateContentRequest
mapGenerateContentResponse
mapPromptFeedback
processGenerateContentResponse
processStream
registerAI
validateChatHistory

36 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
constructRequest
countTokens
countTokensOnCloud
createEnhancedContentResponse
decodeInstanceIdentifier
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentOnCloud
generateContentStream
generateContentStreamOnCloud
generateResponseSequence
getClientHeaders
getFunctionCalls
getGenerativeModel
getHeaders
getInlineDataParts
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
mapCountTokensRequest
mapGenerateContentCandidates
mapGenerateContentRequest
mapGenerateContentResponse
mapPromptFeedback
processGenerateContentResponse
processStream
registerAI
validateChatHistory

+ countTokensOnCloud
+ generateContentOnCloud
+ generateContentStreamOnCloud

classes

AIError
AIModel
AIService
Backend
ChatSession
GenerativeModel
GoogleAIBackend
RequestUrl
VertexAIBackend

AIError
AIModel
AIService
Backend
ChatSession
ChromeAdapterImpl
GenerativeModel
GoogleAIBackend
RequestUrl
VertexAIBackend

+ ChromeAdapterImpl

variables

22 dependencies

AIErrorCode
AI_TYPE
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
FinishReason
HarmSeverity
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
badFinishReasons
logger
name
responseLineRE
version

25 dependencies

AIErrorCode
AI_TYPE
Availability
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_HYBRID_IN_CLOUD_MODEL
DEFAULT_LOCATION
FinishReason
HarmSeverity
InferenceMode
LANGUAGE_TAG
PACKAGE_VERSION
POSSIBLE_ROLES
SILENT_ERROR
Task
VALID_PARTS_PER_ROLE
VALID_PART_FIELDS
VALID_PREVIOUS_CONTENT_ROLES
badFinishReasons
logger
name
responseLineRE
version

+ Availability
+ DEFAULT_HYBRID_IN_CLOUD_MODEL
+ InferenceMode

`getImagenModel`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	9.00 kB	9.15 kB	+154 B (+1.7%)
size-with-ext-deps	26.7 kB	26.8 kB	+157 B (+0.6%)

Dependency

Type Base (56fbe52) Merge (75f6f28) Diff

variables

13 dependencies

AIErrorCode
AI_TYPE
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
LANGUAGE_TAG
PACKAGE_VERSION
Task
logger
name
version

14 dependencies

AIErrorCode
AI_TYPE
Availability
BackendType
DEFAULT_API_VERSION
DEFAULT_BASE_URL
DEFAULT_FETCH_TIMEOUT_MS
DEFAULT_LOCATION
LANGUAGE_TAG
PACKAGE_VERSION
Task
logger
name
version

+ Availability

@firebase/app-check
- initializeAppCheck
  Size
  Type Base (56fbe52) Merge (75f6f28) Diff
  size 11.5 kB 11.5 kB +10 B (+0.1%)
  size-with-ext-deps 36.2 kB 36.2 kB +10 B (+0.0%)
@firebase/firestore
- runTransaction
  Size
  Type Base (56fbe52) Merge (75f6f28) Diff
  size 139 kB 139 kB +1 B (+0.0%)
  size-with-ext-deps 211 kB 211 kB +1 B (+0.0%)

`@firebase/functions`

connectFunctionsEmulator
Size
Type Base (56fbe52) Merge (75f6f28) Diff
size 2.84 kB 2.85 kB +12 B (+0.4%)
size-with-ext-deps 25.0 kB 25.1 kB +12 B (+0.0%)
getFunctions
Size
Type Base (56fbe52) Merge (75f6f28) Diff
size 3.03 kB 3.04 kB +12 B (+0.4%)
size-with-ext-deps 32.6 kB 32.6 kB +12 B (+0.0%)

`httpsCallable`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	8.48 kB	8.62 kB	+141 B (+1.7%)
size-with-ext-deps	26.2 kB	26.5 kB	+284 B (+1.1%)

Dependency

Type Base (56fbe52) Merge (75f6f28) Diff

functions

16 dependencies

_errorForResponse
call
callAtURL
codeForHTTPStatus
createResponseStream
decode
encode
failAfter
httpsCallable
httpsCallable$1
makeAuthHeaders
mapValues
postJSON
registerFunctions
stream
streamAtURL

17 dependencies

_errorForResponse
call
callAtURL
codeForHTTPStatus
createResponseStream
decode
encode
failAfter
getCredentials
httpsCallable
httpsCallable$1
makeAuthHeaders
mapValues
postJSON
registerFunctions
stream
streamAtURL

+ getCredentials

External Dependency

Module	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
`@firebase/util`	FirebaseError getModularInstance	FirebaseError getModularInstance isCloudWorkstation	+ isCloudWorkstation

`httpsCallableFromURL`

Size

Type	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
size	8.37 kB	8.51 kB	+141 B (+1.7%)
size-with-ext-deps	26.1 kB	26.4 kB	+284 B (+1.1%)

Dependency

Type Base (56fbe52) Merge (75f6f28) Diff

functions

14 dependencies

_errorForResponse
callAtURL
codeForHTTPStatus
createResponseStream
decode
encode
failAfter
httpsCallableFromURL
httpsCallableFromURL$1
makeAuthHeaders
mapValues
postJSON
registerFunctions
streamAtURL

15 dependencies

_errorForResponse
callAtURL
codeForHTTPStatus
createResponseStream
decode
encode
failAfter
getCredentials
httpsCallableFromURL
httpsCallableFromURL$1
makeAuthHeaders
mapValues
postJSON
registerFunctions
streamAtURL

+ getCredentials

External Dependency

Module	Base (`56fbe52`)	Merge (`75f6f28`)	Diff
`@firebase/util`	FirebaseError getModularInstance	FirebaseError getModularInstance isCloudWorkstation	+ isCloudWorkstation

@firebase/performance
- getPerformance
  Size
  Type Base (56fbe52) Merge (75f6f28) Diff
  size 19.1 kB 19.2 kB +94 B (+0.5%)
  size-with-ext-deps 61.8 kB 61.9 kB +96 B (+0.2%)
- initializePerformance
  Size
  Type Base (56fbe52) Merge (75f6f28) Diff
  size 19.3 kB 19.3 kB +94 B (+0.5%)
  size-with-ext-deps 55.4 kB 55.5 kB +96 B (+0.2%)
- trace
  Size
  Type Base (56fbe52) Merge (75f6f28) Diff
  size 19.0 kB 19.1 kB +94 B (+0.5%)
  size-with-ext-deps 54.8 kB 54.9 kB +96 B (+0.2%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/06dcYI9pTf.html

github-actions · 2025-07-21T19:28:46Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

.changeset/spotty-bananas-fry.md

MarkDuckworth

Otherwise, LGTM

packages/firestore/src/core/transaction_runner.ts

Fix empty message reject in transaction body

42ed26d

cherylEnkidu requested review from a team as code owners July 21, 2025 18:59

add changeset

99e6d59

cherylEnkidu requested a review from a team as a code owner July 21, 2025 19:27

cherylEnkidu changed the title ~~Fix empty message reject inside transaction body~~ fix(firestore): fix empty message reject inside transaction body Jul 21, 2025

dconeybe requested changes Jul 21, 2025

View reviewed changes

.changeset/spotty-bananas-fry.md Outdated Show resolved Hide resolved

MarkDuckworth approved these changes Jul 21, 2025

View reviewed changes

packages/firestore/src/core/transaction_runner.ts Outdated Show resolved Hide resolved

address feedbacks

b1a4873

cherylEnkidu assigned MarkDuckworth and dconeybe Jul 24, 2025

cherylEnkidu and others added 2 commits July 29, 2025 22:35

address feedbacks 2

56ca0e1

PR feedback - error? to Error | undefined

4714c7a

MarkDuckworth requested a review from dconeybe August 18, 2025 18:59

dconeybe approved these changes Aug 18, 2025

View reviewed changes

MarkDuckworth merged commit 2058432 into main Aug 18, 2025
66 of 69 checks passed

MarkDuckworth deleted the cheryllin/oncall9147 branch August 18, 2025 20:08

google-oss-bot mentioned this pull request Aug 27, 2025

Version Packages #9230

Merged

fix(firestore): fix empty message reject inside transaction body #9177

fix(firestore): fix empty message reject inside transaction body #9177

Uh oh!

Conversation

cherylEnkidu commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

google-oss-bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/ai

@firebase/app-check

@firebase/firestore

@firebase/firestore-lite

@firebase/functions

@firebase/performance

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/ai

AIError

AIErrorCode

AIModel

AnyOfSchema

ArraySchema

Backend

BackendType

BlockReason

BooleanSchema

ChatSession

FinishReason

FunctionCallingMode

GenerativeModel

GoogleAIBackend

HarmBlockMethod

HarmBlockThreshold

HarmCategory

HarmProbability

HarmSeverity

ImagenAspectRatio

ImagenImageFormat

ImagenModel

ImagenPersonFilterLevel

ImagenSafetyFilterLevel

InferenceMode

IntegerSchema

Modality

NumberSchema

ObjectSchema

POSSIBLE_ROLES

ResponseModality

Schema

SchemaType

StringSchema

VertexAIBackend

getAI

getGenerativeModel

getImagenModel

@firebase/app-check

initializeAppCheck

@firebase/firestore

runTransaction

@firebase/functions

connectFunctionsEmulator

getFunctions

httpsCallable

httpsCallableFromURL

@firebase/performance

getPerformance

initializePerformance

cherylEnkidu commented Jul 21, 2025 •

edited

Loading

changeset-bot bot commented Jul 21, 2025 •

edited

Loading

google-oss-bot commented Jul 21, 2025 •

edited

Loading

Size Report ¹

`@firebase/ai`

`@firebase/app-check`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/functions`

`@firebase/performance`

`bundle`

`firebase`

google-oss-bot commented Jul 21, 2025 •

edited

Loading

Size Analysis Report ¹

`@firebase/ai`

`AIError`

`AIErrorCode`

`AIModel`

`AnyOfSchema`

`ArraySchema`

`Backend`

`BackendType`

`BlockReason`

`BooleanSchema`

`ChatSession`

`FinishReason`

`FunctionCallingMode`

`GenerativeModel`

`GoogleAIBackend`

`HarmBlockMethod`

`HarmBlockThreshold`

`HarmCategory`

`HarmProbability`

`HarmSeverity`

`ImagenAspectRatio`

`ImagenImageFormat`

`ImagenModel`

`ImagenPersonFilterLevel`

`ImagenSafetyFilterLevel`

`InferenceMode`

`IntegerSchema`

`Modality`

`NumberSchema`

`ObjectSchema`

`POSSIBLE_ROLES`

`ResponseModality`

`Schema`

`SchemaType`

`StringSchema`

`VertexAIBackend`

`getAI`

`getGenerativeModel`

`getImagenModel`

`@firebase/app-check`

`initializeAppCheck`

`@firebase/firestore`

`runTransaction`

`@firebase/functions`

`connectFunctionsEmulator`

`getFunctions`

`httpsCallable`

`httpsCallableFromURL`

`@firebase/performance`

`getPerformance`

`initializePerformance`

`trace`

github-actions bot commented Jul 21, 2025 •

edited

Loading