Skip to content

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 6, 2022

@hsubox76 hsubox76 requested a review from allspain as a code owner May 6, 2022 22:03
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2022

⚠️ No Changeset found

Latest commit: d82bb09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 requested a review from lahirumaramba May 6, 2022 22:03
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment.

inputs:
version:
description: 'Release version'
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set the version from the Github UI?
If we would like I think we can extract the version from the package.json as well (could be an improvement for later)
see: https://github.com/firebase/firebase-admin-node/blob/a32195daa9848b261fe892d9f606152a40ff2915/.github/scripts/publish_preflight_check.sh#L61

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added this, if you want to take another look. I tested it out with the merge step commented out and it seems to work up to that point.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 6, 2022

Size Report 1

Affected Products

  • @firebase/analytics-compat

    TypeBase (6f10699)Merge (49248e9)Diff
    browser2.57 kB2.57 kB+1 B (+0.0%)
    esm52.80 kB2.80 kB+1 B (+0.0%)
    main3.24 kB3.24 kB+1 B (+0.0%)
    module2.57 kB2.57 kB+1 B (+0.0%)
  • @firebase/auth/cordova

    TypeBase (6f10699)Merge (49248e9)Diff
    browser183 kB183 kB-1 B (-0.0%)
    module183 kB183 kB-1 B (-0.0%)
  • @firebase/auth/internal

    TypeBase (6f10699)Merge (49248e9)Diff
    browser166 kB166 kB-1 B (-0.0%)
    esm5216 kB216 kB-1 B (-0.0%)
    main183 kB183 kB-1 B (-0.0%)
    module166 kB166 kB-1 B (-0.0%)
  • @firebase/auth/react-native

    TypeBase (6f10699)Merge (49248e9)Diff
    browser168 kB168 kB-1 B (-0.0%)
    module168 kB168 kB-1 B (-0.0%)
  • bundle

    TypeBase (6f10699)Merge (49248e9)Diff
    auth (Anonymous)66.0 kB66.0 kB-1 B (-0.0%)
    auth (EmailAndPassword)70.1 kB70.1 kB-1 B (-0.0%)
    auth (GoogleFBTwitterGitHubPopup)89.9 kB89.9 kB-1 B (-0.0%)
    auth (GooglePopup)89.7 kB89.7 kB-1 B (-0.0%)
    auth (GoogleRedirect)89.9 kB89.9 kB-1 B (-0.0%)
    auth (Phone)76.1 kB76.1 kB-1 B (-0.0%)
  • firebase

    TypeBase (6f10699)Merge (49248e9)Diff
    firebase-analytics-compat.js25.6 kB25.6 kB+1 B (+0.0%)
    firebase-auth-compat.js124 kB124 kB-1 B (-0.0%)
    firebase-auth-cordova.js471 kB471 kB-1 B (-0.0%)
    firebase-auth-react-native.js495 kB495 kB-1 B (-0.0%)
    firebase-auth.js417 kB417 kB-1 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vfegisCBKe.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 6, 2022

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.4 kB31.4 kB-1 B (-0.0%)
      size-with-ext-deps51.0 kB51.0 kB-1 B (-0.0%)
    • ActionCodeURL

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.2 kB32.2 kB-1 B (-0.0%)
      size-with-ext-deps52.1 kB52.1 kB-1 B (-0.0%)
    • AuthCredential

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.4 kB31.4 kB-1 B (-0.0%)
      size-with-ext-deps51.0 kB51.0 kB-1 B (-0.0%)
    • AuthErrorCodes

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size35.8 kB35.8 kB-1 B (-0.0%)
      size-with-ext-deps55.4 kB55.4 kB-1 B (-0.0%)
    • EmailAuthCredential

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size33.3 kB33.3 kB-1 B (-0.0%)
      size-with-ext-deps52.9 kB52.9 kB-1 B (-0.0%)
    • EmailAuthProvider

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size34.7 kB34.7 kB-1 B (-0.0%)
      size-with-ext-deps54.6 kB54.6 kB-1 B (-0.0%)
    • FacebookAuthProvider

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size36.3 kB36.3 kB-1 B (-0.0%)
      size-with-ext-deps55.9 kB55.9 kB-1 B (-0.0%)
    • FactorId

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • GithubAuthProvider

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size36.3 kB36.3 kB-1 B (-0.0%)
      size-with-ext-deps55.9 kB55.9 kB-1 B (-0.0%)
    • GoogleAuthProvider

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size36.3 kB36.3 kB-1 B (-0.0%)
      size-with-ext-deps55.9 kB55.9 kB-1 B (-0.0%)
    • OAuthCredential

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size33.4 kB33.4 kB-1 B (-0.0%)
      size-with-ext-deps53.0 kB53.0 kB-1 B (-0.0%)
    • OAuthProvider

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size37.3 kB37.3 kB-1 B (-0.0%)
      size-with-ext-deps56.9 kB56.9 kB-1 B (-0.0%)
    • OperationType

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • PhoneAuthCredential

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size33.4 kB33.4 kB-1 B (-0.0%)
      size-with-ext-deps53.0 kB53.0 kB-1 B (-0.0%)
    • PhoneAuthProvider

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size35.1 kB35.1 kB-1 B (-0.0%)
      size-with-ext-deps54.7 kB54.7 kB-1 B (-0.0%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.1 kB32.1 kB-1 B (-0.0%)
      size-with-ext-deps51.7 kB51.7 kB-1 B (-0.0%)
    • ProviderId

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.3 kB31.3 kB-1 B (-0.0%)
      size-with-ext-deps50.9 kB50.9 kB-1 B (-0.0%)
    • RecaptchaVerifier

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size37.6 kB37.6 kB-1 B (-0.0%)
      size-with-ext-deps57.2 kB57.2 kB-1 B (-0.0%)
    • SAMLAuthProvider

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size37.6 kB37.6 kB-1 B (-0.0%)
      size-with-ext-deps57.2 kB57.2 kB-1 B (-0.0%)
    • SignInMethod

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.3 kB31.3 kB-1 B (-0.0%)
      size-with-ext-deps50.9 kB50.9 kB-1 B (-0.0%)
    • TwitterAuthProvider

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size36.3 kB36.3 kB-1 B (-0.0%)
      size-with-ext-deps55.9 kB55.9 kB-1 B (-0.0%)
    • applyActionCode

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.4 kB31.4 kB-1 B (-0.0%)
      size-with-ext-deps51.0 kB51.0 kB-1 B (-0.0%)
    • beforeAuthStateChanged

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • browserLocalPersistence

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size34.5 kB34.5 kB-1 B (-0.0%)
      size-with-ext-deps54.2 kB54.2 kB-1 B (-0.0%)
    • browserPopupRedirectResolver

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size55.5 kB55.5 kB-1 B (-0.0%)
      size-with-ext-deps75.3 kB75.3 kB-1 B (-0.0%)
    • browserSessionPersistence

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size34.5 kB34.5 kB-1 B (-0.0%)
      size-with-ext-deps54.2 kB54.2 kB-1 B (-0.0%)
    • checkActionCode

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.3 kB32.3 kB-1 B (-0.0%)
      size-with-ext-deps51.9 kB51.9 kB-1 B (-0.0%)
    • confirmPasswordReset

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.4 kB31.4 kB-1 B (-0.0%)
      size-with-ext-deps51.0 kB51.0 kB-1 B (-0.0%)
    • connectAuthEmulator

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.9 kB32.9 kB-1 B (-0.0%)
      size-with-ext-deps52.5 kB52.5 kB-1 B (-0.0%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.3 kB32.3 kB-1 B (-0.0%)
      size-with-ext-deps51.9 kB51.9 kB-1 B (-0.0%)
    • debugErrorMap

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size42.3 kB42.3 kB-1 B (-0.0%)
      size-with-ext-deps61.9 kB61.9 kB-1 B (-0.0%)
    • deleteUser

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.6 kB31.6 kB-1 B (-0.0%)
      size-with-ext-deps51.2 kB51.2 kB-1 B (-0.0%)
    • getAdditionalUserInfo

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.5 kB32.5 kB-1 B (-0.0%)
      size-with-ext-deps52.1 kB52.1 kB-1 B (-0.0%)
    • getAuth

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size63.2 kB63.2 kB-1 B (-0.0%)
      size-with-ext-deps83.6 kB83.6 kB-1 B (-0.0%)
    • getIdToken

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • getIdTokenResult

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.1 kB31.1 kB-1 B (-0.0%)
      size-with-ext-deps50.7 kB50.7 kB-1 B (-0.0%)
    • getMultiFactorResolver

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size33.9 kB33.9 kB-1 B (-0.0%)
      size-with-ext-deps53.5 kB53.5 kB-1 B (-0.0%)
    • getRedirectResult

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size38.8 kB38.8 kB-1 B (-0.0%)
      size-with-ext-deps58.4 kB58.4 kB-1 B (-0.0%)
    • inMemoryPersistence

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.7 kB50.7 kB-1 B (-0.0%)
    • indexedDBLocalPersistence

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size38.6 kB38.6 kB-1 B (-0.0%)
      size-with-ext-deps58.2 kB58.2 kB-1 B (-0.0%)
    • initializeAuth

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.4 kB31.4 kB-1 B (-0.0%)
      size-with-ext-deps51.5 kB51.5 kB-1 B (-0.0%)
    • isSignInWithEmailLink

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.4 kB32.4 kB-1 B (-0.0%)
      size-with-ext-deps52.2 kB52.2 kB-1 B (-0.0%)
    • linkWithCredential

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.2 kB32.2 kB-1 B (-0.0%)
      size-with-ext-deps51.8 kB51.8 kB-1 B (-0.0%)
    • linkWithPhoneNumber

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size35.9 kB35.9 kB-1 B (-0.0%)
      size-with-ext-deps55.5 kB55.5 kB-1 B (-0.0%)
    • linkWithPopup

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size42.4 kB42.4 kB-1 B (-0.0%)
      size-with-ext-deps62.0 kB62.0 kB-1 B (-0.0%)
    • linkWithRedirect

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size37.6 kB37.6 kB-1 B (-0.0%)
      size-with-ext-deps57.2 kB57.2 kB-1 B (-0.0%)
    • multiFactor

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size33.4 kB33.3 kB-1 B (-0.0%)
      size-with-ext-deps52.9 kB52.9 kB-1 B (-0.0%)
    • onAuthStateChanged

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • onIdTokenChanged

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • parseActionCodeURL

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.3 kB32.3 kB-1 B (-0.0%)
      size-with-ext-deps52.1 kB52.1 kB-1 B (-0.0%)
    • prodErrorMap

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.1 kB31.1 kB-1 B (-0.0%)
      size-with-ext-deps50.7 kB50.7 kB-1 B (-0.0%)
    • reauthenticateWithCredential

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.8 kB32.8 kB-1 B (-0.0%)
      size-with-ext-deps52.3 kB52.3 kB-1 B (-0.0%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size36.4 kB36.4 kB-1 B (-0.0%)
      size-with-ext-deps56.0 kB56.0 kB-1 B (-0.0%)
    • reauthenticateWithPopup

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size42.4 kB42.4 kB-1 B (-0.0%)
      size-with-ext-deps62.0 kB62.0 kB-1 B (-0.0%)
    • reauthenticateWithRedirect

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size37.3 kB37.3 kB-1 B (-0.0%)
      size-with-ext-deps56.9 kB56.9 kB-1 B (-0.0%)
    • reload

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.1 kB31.1 kB-1 B (-0.0%)
      size-with-ext-deps50.7 kB50.7 kB-1 B (-0.0%)
    • sendEmailVerification

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.2 kB32.2 kB-1 B (-0.0%)
      size-with-ext-deps51.8 kB51.8 kB-1 B (-0.0%)
    • sendPasswordResetEmail

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.1 kB32.1 kB-1 B (-0.0%)
      size-with-ext-deps51.7 kB51.7 kB-1 B (-0.0%)
    • sendSignInLinkToEmail

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.2 kB32.2 kB-1 B (-0.0%)
      size-with-ext-deps51.7 kB51.7 kB-1 B (-0.0%)
    • setPersistence

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • signInAnonymously

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.4 kB32.4 kB-1 B (-0.0%)
      size-with-ext-deps52.0 kB52.0 kB-1 B (-0.0%)
    • signInWithCredential

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.5 kB32.5 kB-1 B (-0.0%)
      size-with-ext-deps52.1 kB52.1 kB-1 B (-0.0%)
    • signInWithCustomToken

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.3 kB32.3 kB-1 B (-0.0%)
      size-with-ext-deps51.9 kB51.9 kB-1 B (-0.0%)
    • signInWithEmailAndPassword

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size36.2 kB36.2 kB-1 B (-0.0%)
      size-with-ext-deps56.0 kB56.0 kB-1 B (-0.0%)
    • signInWithEmailLink

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size36.4 kB36.4 kB-1 B (-0.0%)
      size-with-ext-deps56.2 kB56.2 kB-1 B (-0.0%)
    • signInWithPhoneNumber

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size36.2 kB36.2 kB-1 B (-0.0%)
      size-with-ext-deps55.8 kB55.8 kB-1 B (-0.0%)
    • signInWithPopup

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size42.4 kB42.4 kB-1 B (-0.0%)
      size-with-ext-deps62.0 kB62.0 kB-1 B (-0.0%)
    • signInWithRedirect

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size37.0 kB37.0 kB-1 B (-0.0%)
      size-with-ext-deps56.6 kB56.6 kB-1 B (-0.0%)
    • signOut

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • unlink

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.8 kB31.7 kB-1 B (-0.0%)
      size-with-ext-deps51.3 kB51.3 kB-1 B (-0.0%)
    • updateCurrentUser

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • updateEmail

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.5 kB31.5 kB-1 B (-0.0%)
      size-with-ext-deps51.1 kB51.1 kB-1 B (-0.0%)
    • updatePassword

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.5 kB31.5 kB-1 B (-0.0%)
      size-with-ext-deps51.1 kB51.1 kB-1 B (-0.0%)
    • updatePhoneNumber

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.9 kB31.9 kB-1 B (-0.0%)
      size-with-ext-deps51.5 kB51.5 kB-1 B (-0.0%)
    • updateProfile

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.7 kB31.7 kB-1 B (-0.0%)
      size-with-ext-deps51.2 kB51.2 kB-1 B (-0.0%)
    • useDeviceLanguage

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size31.2 kB31.2 kB-1 B (-0.0%)
      size-with-ext-deps50.8 kB50.8 kB-1 B (-0.0%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.2 kB32.2 kB-1 B (-0.0%)
      size-with-ext-deps51.8 kB51.8 kB-1 B (-0.0%)
    • verifyPasswordResetCode

      Size

      TypeBase (6f10699)Merge (49248e9)Diff
      size32.4 kB32.4 kB-1 B (-0.0%)
      size-with-ext-deps52.0 kB52.0 kB-1 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PU5Q8neHXx.html

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@hsubox76 hsubox76 merged commit f43b2b4 into master May 10, 2022
@hsubox76 hsubox76 deleted the ch-merge-workflow branch May 10, 2022 20:39
@firebase firebase locked and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants