Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/abtesting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
paths:
- 'FirebaseABTesting**'
- 'Interop/Analytics/Public/*.h'
- '.github/workflows/abtesting.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- '.github/workflows/common_quickstart.yml'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/appdistribution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
pull_request:
paths:
- 'FirebaseAppDistribution**'
- '.github/workflows/appdistribution.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- 'Gemfile*'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/auth.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
paths:
- 'FirebaseAuth**'
- 'FirebaseAuth/Interop/*.h'
- '.github/workflows/auth.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- '.github/workflows/common_quickstart.yml'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ jobs:
if: (github.repository == 'firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name)
needs: [spm-package-resolved]
strategy:
# max-parallel: 1 # ${{ inputs.parallel_testing_enabled == true && 99 || 1 }}
matrix:
os: [macos-15]
xcode: [Xcode_16.4]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
pull_request:
paths:
- 'FirebaseCore**'
- '.github/workflows/core.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- 'Gemfile*'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/core_extension.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
paths:
- 'FirebaseCoreExtension.podspec'
- 'FirebaseCore/Extension/**'
- '.github/workflows/core_extension.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- 'Gemfile*'
schedule:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/core_internal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
paths:
- 'FirebaseCoreInternal.podspec'
- 'FirebaseCore/Internal/**'
- '.github/workflows/core_internal.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- 'Gemfile*'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/crashlytics.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: crashlytics

#
permissions:
contents: read

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/database.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ on:
- 'FirebaseSharedSwift**'
- 'Example/Database/**'
- 'FirebaseAuth/Interop/*.h'
- '.github/workflows/database.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- '.github/workflows/common_quickstart.yml'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/firebase_app_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
pull_request:
paths:
- 'FirebaseAppCheck**'
- '.github/workflows/firebase_app_check.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- 'Gemfile*'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/firebaseai.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ on:
pull_request:
paths:
- 'FirebaseAI**'
- '.github/workflows/firebaseai.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- 'scripts/quickstart_build_spm.sh'
- 'scripts/quickstart_spm_xcodeproj.sh'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/functions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
paths:
- 'FirebaseFunctions**'
- 'FirebaseSharedSwift**'
- '.github/workflows/functions.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- 'FirebaseAuth/Interop/*.h'
- 'FirebaseMessaging/Interop/*.h'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/inappmessaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
paths:
- 'FirebaseInAppMessaging**'
- 'Interop/Analytics/Public/*.h'
- '.github/workflows/inappmessaging.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_quickstart.yml'
- 'Gemfile*'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/installations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
pull_request:
paths:
- 'FirebaseInstallations**'
- '.github/workflows/installations.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- '.github/workflows/common_quickstart.yml'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/mlmodeldownloader.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
pull_request:
paths:
- 'FirebaseMLModelDownloader**'
- '.github/workflows/mlmodeldownloader.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- 'Gemfile*'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/remoteconfig.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
paths:
- 'FirebaseRemoteConfig**'
- 'Interop/Analytics/Public/*.h'
- '.github/workflows/remoteconfig.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- '.github/workflows/common_quickstart.yml'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sessions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
paths:
- 'FirebaseSessions**'
- 'FirebaseSessions.podspec'
- '.github/workflows/sessions.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- 'Gemfile*'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/shared-swift.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
pull_request:
paths:
- 'FirebaseSharedSwift**'
- '.github/workflows/shared-swift.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- 'Gemfile*'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/storage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
paths:
- 'FirebaseStorage**'
- 'FirebaseAuth/Interop/*.h'
- '.github/workflows/storage.yml'
- '.github/workflows/common.yml'
# - '.github/workflows/.*'
# - '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- '.github/workflows/common_catalyst.yml'
- '.github/workflows/common_quickstart.yml'
Expand Down
9 changes: 5 additions & 4 deletions Crashlytics/Crashlytics/Models/FIRCLSSettings.m
Original file line number Diff line number Diff line change
Expand Up @@ -189,16 +189,17 @@ - (NSDictionary *)loadCacheKey {
}

- (void)deleteCachedSettings {
__weak FIRCLSSettings *weakSelf = self;
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
__strong FIRCLSSettings *strongSelf = weakSelf;

// __weak FIRCLSSettings *weakSelf = self;
// dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
__strong FIRCLSSettings *strongSelf = self; //weakSelf;
if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsFilePath]) {
[strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsFilePath];
}
if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsCacheKeyPath]) {
[strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsCacheKeyPath];
}
});
// });

@synchronized(self) {
self.isCacheKeyExpired = YES;
Expand Down
Loading