Skip to content

Conversation

dconeybe
Copy link
Contributor

Downgrade grpc CocoaPods dependency to 1.44.0 (was 1.50.1) as a workaround for a Firestore crash on iOS 12 that happens with with grpc 1.50.0 and newer: #11509. Leave the cmake and swift package manager dependencies at 1.50 since they do not experience this crash.

A workaround for this crash is planned to be merged into grpc upstream (grpc/grpc#34416). Once released (and a few other unrelated grpc build issues with Firestore are fixed) the grpc dependency will be re-upgraded to a version that includes the workaround.

Note: This PR effectively reverts #10650.

Fixes #11509

Leave the cmake and swift package manager dependencies at 1.50 since they do not experience this crash.

This is a workaround for a Firestore crash on iOS 12 with grpc 1.50.0 and newer: #11509
@dconeybe dconeybe self-assigned this Sep 25, 2023
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.15% (d9705e6) to 88.16% (8460712) by +0.01%.

    FilenameBase (d9705e6)Merge (8460712)Diff
    leveldb_mutation_queue.cc92.42%93.56%+1.14%
    ordered_code.cc93.90%94.39%+0.49%
    task.cc96.52%94.78%-1.74%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zThF84ZoMh.html

@dconeybe dconeybe marked this pull request as ready for review September 25, 2023 16:26
@dconeybe dconeybe requested a review from wu-hui September 25, 2023 16:26
@dconeybe dconeybe merged commit 15a99f0 into master Sep 25, 2023
@dconeybe dconeybe deleted the dconeybe/GrpcDowngradeTo_1_44_0_From_1_50_1 branch September 25, 2023 16:27
@paulb777 paulb777 added this to the 10.16.0 - M138 milestone Sep 25, 2023
@firebase firebase locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashed: com.google.firebase.firestore grpc::SecureChannelCredentials::~SecureChannelCredentials()
3 participants