Skip to content

[Messaging] - Fix crash for strongSelf dereference #10740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 27, 2023
Merged

[Messaging] - Fix crash for strongSelf dereference #10740

merged 4 commits into from
Jan 27, 2023

Conversation

@aashishpatil-g
Copy link
Contributor

@aashishpatil-g aashishpatil-g commented Jan 26, 2023 •
edited
Loading

Discussion

Fix for #10707

Added a check for self within the block. Found some other places in the file and fixed those too.

#no-changelog

@aashishpatil-g aashishpatil-g linked an issue Jan 26, 2023 that may be closed by this pull request
Possible crash if FIRMessagingTokenManager is dealloc'ed while a token fetch is in progress #10707
Closed
charlotteliang
charlotteliang approved these changes Jan 26, 2023
View reviewed changes
@google-oss-bot
Copy link

google-oss-bot commented Jan 26, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.59% (4171a3b) to 60.21% (15ee3d6) by -0.39%.

    FilenameBase (4171a3b)Merge (15ee3d6)Diff
    FIRMessagingTokenManager.m15.56%14.82%-0.73%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EA2mtAqASE.html

@aashishpatil-g aashishpatil-g merged commit d9e19cd into master Jan 27, 2023
@aashishpatil-g aashishpatil-g deleted the ap/self-dereference-crash branch January 27, 2023 20:25
@aashishpatil-g aashishpatil-g added this to the 10.5.0 - M127 milestone Jan 27, 2023
@firebase firebase locked and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees

No one assigned

Labels

api: messaging

Projects

None yet

Milestone

10.5.0 - M127

Development

Successfully merging this pull request may close these issues.

Possible crash if FIRMessagingTokenManager is dealloc'ed while a token fetch is in progress

4 participants

@aashishpatil-g @google-oss-bot @paulb777 @charlotteliang