Skip to content

Conversation

@taeold
Copy link
Contributor

@taeold taeold commented Nov 4, 2025

Fixes CI publish failure for prereleases by adding the required --tag next flag to npm publish when PRE_RELEASE is set.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue in the continuous integration pipeline where prerelease versions were failing to publish correctly to npm. By modifying the publish.sh script, it now dynamically appends the --tag next argument to the npm publish command specifically for prereleases, ensuring that these versions are properly tagged and published without manual intervention or errors.

Highlights

  • CI/CD Publishing Fix: Resolves CI publish failures for prereleases by ensuring the npm publish command includes the --tag next flag when a prerelease is detected.
  • Script Refactoring: Introduces a PUBLISH_ARGS variable in scripts/publish.sh to consolidate and conditionally apply arguments to the npm publish command, improving readability and maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@taeold taeold requested a review from jhuleatt November 4, 2025 20:26
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the --tag next flag for npm prereleases. My review focuses on improving the robustness of the shell script. I've suggested using a bash array to construct the command-line arguments for npm publish. This is a safer and more maintainable approach than string concatenation, as it avoids potential issues with word splitting and quoting.

@taeold taeold requested a review from brittanycho November 4, 2025 20:29
@taeold taeold added this pull request to the merge queue Nov 4, 2025
Merged via the queue into master with commit 7f435e2 Nov 4, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants