Add option to get named firestore instance for v2 firestore functions #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blidd-google
approved these changes
Apr 10, 2024
Contributor
blidd-google
left a comment
blidd-google
left a comment
There was a problem hiding this comment.
LGTM besides minor nit
| export function createSnapshotFromProtobuf(data: Uint8Array, path: string, databaseId: string) { | ||
| if (!firestoreInstance) { | ||
| firestoreInstance = firestore.getFirestore(getApp()); | ||
| firestoreInstance = firestore.getFirestore(databaseId); |
Contributor
There was a problem hiding this comment.
Curious, why aren't you conditioning on firestoreInstance here like in createBeforeSnapshotFromBeforeProtobuf?
Contributor
Author
There was a problem hiding this comment.
You mean conditioning on databaseId right?
Because these two *fromProtobuf functions are only called from the V2 handler and V2 events always supply the databaseId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes firebase/firebase-tools#6971