Skip to content

Unbreak TS users by removing internal annotations for non-internal type definitions. #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2022
Merged

Unbreak TS users by removing internal annotations for non-internal type definitions. #1032

merged 3 commits into from
Feb 4, 2022

Conversation

@taeold
Copy link
Contributor

@taeold taeold commented Feb 4, 2022

Fixes #1031

@taeold taeold requested review from colerogers and inlined February 4, 2022 05:19
@taeold taeold merged commit 43fc634 into master Feb 4, 2022
@taeold taeold mentioned this pull request Feb 7, 2022
Merged
taeold added a commit that referenced this pull request Feb 7, 2022
@taeold
Unbreak v2 TS users by safely removing duplicated manifest definition (…
9da9a4e 
…#1033)

Follows up #1032 for V2 API to fix #1031.

While rebasing the branch that moved the location of manifest definition (#1003), the original file was not removed and cleaned up. Having long-lasting PR is dangeroud 🤦🏼‍♂️ .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colerogers colerogers colerogers approved these changes

@inlined inlined Awaiting requested review from inlined

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error TS2305: Module '"./common/manifest"' has no exported member 'ManifestEndpoint'

2 participants

@taeold @colerogers