Skip to content
Lint

Modify Analytics on desktop to use a verified DLL on Windows (although it is currently still a stub). #5062

Sign in to view logs

Modify Analytics on desktop to use a verified DLL on Windows (although it is currently still a stub).

Modify Analytics on desktop to use a verified DLL on Windows (although it is currently still a stub). #5062

Triggered via pull request August 26, 2025 21:56
@a-mauricea-maurice
synchronize #1731
analytics-dll-secure
Status Success
Total duration 1m 18s
Artifacts –

lint.yml

on: pull_request
lint_warnings_check_and_comment
1m 15s
lint_warnings_check_and_comment
Fit to window
Zoom out
Zoom in

Annotations

1 warning
lint_warnings_check_and_comment
Found 11 lint warnings: analytics/src/analytics_desktop.cc:49: Static/global string variables are not permitted. [runtime/string] [4] analytics/src/analytics_desktop.cc:50: Static/global string variables are not permitted. [runtime/string] [4] analytics/src/analytics_desktop_dynamic.h:17: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_SRC_ANALYTICS_DESKTOP_DYNAMIC_H_ [build/header_guard] [5] analytics/src/analytics_desktop_dynamic.h:222: #endif line should be "#endif // FIREBASE_ANALYTICS_SRC_ANALYTICS_DESKTOP_DYNAMIC_H_" [build/header_guard] [5] analytics/src/analytics_desktop_dynamic.h:25: "stdbool.h" already included at analytics/src/analytics_desktop_dynamic.h:22 [build/include] [4] analytics/windows/include/public/analytics.h:3: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_ANALYTICS_H_ [build/header_guard] [5] analytics/windows/include/public/c/analytics.h:3: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_C_ANALYTICS_H_ [build/header_guard] [5] analytics/windows/include/public/event_names.h:3: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_EVENT_NAMES_H_ [build/header_guard] [5] analytics/windows/include/public/event_names.h:427: #endif line should be "#endif // FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_EVENT_NAMES_H_" [build/header_guard] [5] analytics/windows/include/public/parameter_names.h:3: #ifndef header guard has wrong style, please use: FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_PARAMETER_NAMES_H_ [build/header_guard] [5] analytics/windows/include/public/parameter_names.h:254: #endif line should be "#endif // FIREBASE_ANALYTICS_WINDOWS_INCLUDE_PUBLIC_PARAMETER_NAMES_H_" [build/header_guard] [5]