Skip to content

Add support for Code Execution #7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add support for Code Execution #7265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c0c2c4
add code exeuction parts
VinayGuthal Aug 18, 2025
dd0dd2e
update api text file
VinayGuthal Aug 18, 2025
6868ce5
update tests
VinayGuthal Aug 18, 2025
38e7e86
update code execution part
VinayGuthal Aug 18, 2025
b9e991b
update according to comments
VinayGuthal Aug 20, 2025
0f74341
Merge branch 'main' into code_execution_support
VinayGuthal Aug 20, 2025
82ba5a4
update parts
VinayGuthal Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions firebase-ai/src/main/kotlin/com/google/firebase/ai/type/GenerateContentResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,18 @@ public class GenerateContentResponse(
candidates.first().content.parts.filterIsInstance<FunctionCallPart>()
}

/**
* Convenience field to list all the [CodeExecutionResultPart]s in the response, if they exist.
*/
public val codeExecutionResults: List<CodeExecutionResultPart> by lazy {
candidates.first().content.parts.filterIsInstance<CodeExecutionResultPart>()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Calling candidates.first() will throw a NoSuchElementException if the candidates list is empty. This can happen if the model returns no candidates in the response, which would cause a crash. To prevent this, you should safely access the first candidate using firstOrNull() and provide a default empty list using the elvis operator ?:.

Suggested change
candidates.first().content.parts.filterIsInstance<CodeExecutionResultPart>()
candidates.firstOrNull()?.content?.parts?.filterIsInstance<CodeExecutionResultPart>() ?: emptyList()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a great catch by Gemini. https://github.com/firebase/firebase-android-sdk/pull/7270/files/04ba803802f8c1e8d2563e2f7384e51a487c9ae3#diff-96bec27f04d310266c9b09f561314e8cd13284ebcc32f2d69ab187ca6e13d3d6 fixes it for other cases

Please address here and below

}

/** Convenience field to list all the [ExecutableCodePart]s in the response, if they exist. */
public val executableCodeList: List<ExecutableCodePart> by lazy {
candidates.first().content.parts.filterIsInstance<ExecutableCodePart>()
}

/**
* Convenience field representing all the [InlineDataPart]s in the first candidate, if they exist.
*
Expand Down
15 changes: 11 additions & 4 deletions firebase-ai/src/main/kotlin/com/google/firebase/ai/type/Tool.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,14 @@ import kotlinx.serialization.json.JsonObject
public class Tool
internal constructor(
internal val functionDeclarations: List<FunctionDeclaration>?,
internal val googleSearch: GoogleSearch?
internal val googleSearch: GoogleSearch?,
internal val codeExecution: JsonObject?,
) {
internal fun toInternal() =
Internal(
functionDeclarations?.map { it.toInternal() } ?: emptyList(),
googleSearch = this.googleSearch?.toInternal()
googleSearch = this.googleSearch?.toInternal(),
codeExecution = this.codeExecution
)
@Serializable
internal data class Internal(
Expand All @@ -49,7 +51,12 @@ internal constructor(
*/
@JvmStatic
public fun functionDeclarations(functionDeclarations: List<FunctionDeclaration>): Tool {
return Tool(functionDeclarations, null)
return Tool(functionDeclarations, null, null)
}

@JvmStatic
public fun codeExecution(): Tool {
return Tool(null, null, JsonObject(emptyMap()))
}

/**
Expand All @@ -70,7 +77,7 @@ internal constructor(
*/
@JvmStatic
public fun googleSearch(googleSearch: GoogleSearch = GoogleSearch()): Tool {
return Tool(null, googleSearch)
return Tool(null, googleSearch, null)
}
}
}
Loading