Skip to content

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Jun 23, 2025

  • Bumped to latest pylint and astroid
  • Updated .pylintrc and removed deprecated configs:
    • This includes removing:

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Jun 23, 2025
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@@ -194,64 +201,33 @@ property-classes=abc.abstractproperty
# Regular expression matching correct function names
function-rgx=[a-z_][a-z0-9_]*$

# Naming hint for function names
function-name-hint=[a-z_][a-z0-9_]*$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a comment on why all these are being removed (for paper-trail purposes) :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, Done!

@jonathanedey jonathanedey merged commit c9dce80 into v7 Jun 26, 2025
13 checks passed
@jonathanedey jonathanedey deleted the je-bump-pylint branch June 26, 2025 13:54
jonathanedey added a commit that referenced this pull request Jul 14, 2025
* change(fcm): Remove deprecated FCM APIs (#890)

* chore(deps): Bump minimum supported Python version to 3.9 and add 3.13 to CIs (#892)

* chore(deps): Bump minimum supported Python version to 3.9 and add 3.13 to CIs

* fix deprecation warnings

* fix GHA build status svg

* fix: Correctly scope async eventloop

* fix: Bump pylint to v2.7.4 and astroid to v2.5.8 to fix lint issues

* fix ml tests

* fix lint

* fix: remove commented code

* change(ml): Drop AutoML model support (#894)

* chore: Bump `pylint` to v3.3.7 and `astroid` to v3.3.10 (#895)

* chore: Bump pylint to v3

* chore: fix src lint

* chore: fix unit test lint

* chore: fix integration test lint

* chore: fix snippets lint

* chore: 2nd pass for errors

* fix: corrected use of the `bad-functions` config

* fix: add EoF newline

* chore: Upgraded Google API Core, Cloud Firestore, and Cloud Storage dependencies (#897)

* chore: Bump dependencies

* fix: Also update setup.py

* fix(functions): Remove usage of deprecated `datetime.utcnow() and fix flaky unit test` (#896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants