Skip to content

fix(auth): Add missing Math.floor() when setting validDuration in createSessionCookie() #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix(auth): Add missing Math.floor() when setting validDuration in createSessionCookie() #2712

merged 3 commits into from
Sep 25, 2024

Conversation

jonathanedey
Copy link
Contributor

  • Add missing Math.floor() when setting validDuration in createSessionCookie()
  • Modified test to use an expiresIn value set to the millisecond to verify this resolves the issue.

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Sep 24, 2024
@jonathanedey jonathanedey linked an issue Sep 24, 2024 that may be closed by this pull request
AuthApiRequest expiresIn transformation is missing Math.round and causes rpc.BadRequest error #2708
Closed
@jonathanedey jonathanedey marked this pull request as ready for review September 24, 2024 18:09
lahirumaramba
lahirumaramba approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonathan! LGTM

@jonathanedey jonathanedey merged commit 137a0d9 into master Sep 25, 2024
10 checks passed
@jonathanedey jonathanedey deleted the je-auth-expires-in branch September 25, 2024 20:12
@kenn7575 kenn7575 mentioned this pull request Oct 27, 2024
Closed
@Erenkrs Erenkrs mentioned this pull request Oct 30, 2024
Open
This was referenced Nov 4, 2024
Merged
Merged
@Erenkrs Erenkrs mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
release:stage Stage a release candidate release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AuthApiRequest expiresIn transformation is missing Math.round and causes rpc.BadRequest error
2 participants
@jonathanedey @lahirumaramba