Support types for NodeJS 12

[sk-]

[REQUIRED] Step 2: Describe your environment

• Firebase SDK version: 9.4.1
• Firebase Product: admin
• Node.js version: 12

[REQUIRED] Step 3: Describe the problem

Now that cloud functions support for NodeJS 12 is at the GA level, the type dependencies should reflect that, so instead of depending on the types for Node 10, it should depend in either the types for node 10 or the types for node 12.

See

firebase-admin-node/package.json

Line 61 in a98a3cc

"@types/node": "^10.10.0",

That line should probably be changed to something like:

"@types/node": "^10.10.0 || ^12"

I'm not sure though if that dependency really needs to be a runtime dependency or it it could be moved to a dev dependency.

Steps to reproduce:

What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

Relevant Code:

// TODO(you): code here to reproduce the problem

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

[hiranya911]

I think we can make it a dev dependency (and is probably the right course of action). I'll take a look in the coming days.

[swftvsn]

This has proven to be a problem for us also. Please consider to work on it.

[nikhilag]

I believe this issue has been fixed in #1258