Skip to content

fix: Map Firebase FIREBASE_STORAGE_EMULATOR_HOST to the Cloud API STORAGE_EMULATOR_HOST #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2023
Merged

fix: Map Firebase FIREBASE_STORAGE_EMULATOR_HOST to the Cloud API STORAGE_EMULATOR_HOST #588

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fed64b7
Mapped firebase storage emulator variable to gcloud equivalent
jonathanedey Oct 2, 2023
f10290f
Added unit test
jonathanedey Oct 2, 2023
b515b9e
fix: also unset STORAGE_EMULATOR_HOST after test
jonathanedey Oct 3, 2023
4bd2b17
fix: unset STORAGE_EMULATOR_HOST before test as well
jonathanedey Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions storage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package storage
import (
"context"
"errors"
"os"

"cloud.google.com/go/storage"
"firebase.google.com/go/v4/internal"
Expand All @@ -34,6 +35,9 @@ type Client struct {
// This function can only be invoked from within the SDK. Client applications should access the
// the Storage service through firebase.App.
func NewClient(ctx context.Context, c *internal.StorageConfig) (*Client, error) {
if os.Getenv("STORAGE_EMULATOR_HOST") == "" && os.Getenv("FIREBASE_STORAGE_EMULATOR_HOST") != "" {
os.Setenv("STORAGE_EMULATOR_HOST", os.Getenv("FIREBASE_STORAGE_EMULATOR_HOST"))
}
client, err := storage.NewClient(ctx, c.Opts...)
if err != nil {
return nil, err
Expand Down
18 changes: 18 additions & 0 deletions storage/storage_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package storage

import (
"context"
"os"
"testing"

"firebase.google.com/go/v4/internal"
Expand All @@ -38,6 +39,23 @@ func TestNewClientError(t *testing.T) {
}
}

func TestNewClientEmulatorHostEnvVar(t *testing.T) {
emulatorHost := "localhost:9099"
os.Setenv("FIREBASE_STORAGE_EMULATOR_HOST", emulatorHost)
defer os.Unsetenv("FIREBASE_STORAGE_EMULATOR_HOST")

_, err := NewClient(context.Background(), &internal.StorageConfig{
Opts: opts,
})
if err != nil {
t.Fatal(err)
}

if host := os.Getenv("STORAGE_EMULATOR_HOST"); host != emulatorHost {
t.Errorf("emulator host: %q; want: %q", host, emulatorHost)
}
}

func TestNoBucketName(t *testing.T) {
client, err := NewClient(context.Background(), &internal.StorageConfig{
Opts: opts,
Expand Down