Skip to content

fix FIREBASE_DATABASE_EMULATOR_HOST not working #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix FIREBASE_DATABASE_EMULATOR_HOST not working #578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions db/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,6 @@ func parseURLConfig(dbURL string) (*dbURLConfig, bool, error) {

environmentEmulatorURL := os.Getenv(emulatorDatabaseEnvVar)
if environmentEmulatorURL != "" {
parsedURL, err = url.ParseRequestURI(environmentEmulatorURL)
if err != nil {
return nil, false, fmt.Errorf("%s: %w", environmentEmulatorURL, errInvalidURL)
}
cfg, err := parseEmulatorHost(environmentEmulatorURL, parsedURL)
return cfg, true, err
}
Expand All @@ -192,23 +188,31 @@ func parseURLConfig(dbURL string) (*dbURLConfig, bool, error) {
}, false, nil
}

func parseEmulatorHost(rawEmulatorHostURL string, parsedEmulatorHost *url.URL) (*dbURLConfig, error) {
if strings.Contains(rawEmulatorHostURL, "//") {
func parseEmulatorHost(rawEmulatorHostURL string, parsedDbURL *url.URL) (*dbURLConfig, error) {
parsedEmulatorURL, err := url.ParseRequestURI("http://" + rawEmulatorHostURL)
if err != nil {
return nil, fmt.Errorf(`invalid %s: "%s". It must follow format "host:port": %w`, emulatorDatabaseEnvVar, rawEmulatorHostURL, errInvalidURL)
}

baseURL := strings.Replace(rawEmulatorHostURL, fmt.Sprintf("?%s", parsedEmulatorHost.RawQuery), "", -1)
if parsedEmulatorHost.Scheme != "http" {
// FIREBASE_DATABASE_EMULATOR_HOST in doc https://firebase.google.com/docs/emulator-suite/connect_rtdb#admin_sdks
// Format should only be host:port, "127.0.0.1:9000"
baseURL := parsedEmulatorURL.Host
if parsedDbURL.Scheme != "http" {
baseURL = fmt.Sprintf("http://%s", baseURL)
}

namespace := parsedEmulatorHost.Query().Get(emulatorNamespaceParam)
namespace := parsedDbURL.Query().Get(emulatorNamespaceParam)
if namespace == "" {
if strings.Contains(rawEmulatorHostURL, ".") {
if strings.Contains(rawEmulatorHostURL, ".") && !strings.Contains(rawEmulatorHostURL, "127.0.0.1") {
namespace = strings.Split(rawEmulatorHostURL, ".")[0]
}
if namespace == "" {
return nil, fmt.Errorf(`invalid database URL: "%s". Database URL must be a valid URL to a Firebase Realtime Database instance (include ?ns=<db-name> query param)`, parsedEmulatorHost)
if namespace == "" {
return nil, fmt.Errorf(`invalid database URL: "%s". Database URL must be a valid URL to a Firebase Realtime Database instance (Emulator URL include ?ns=<db-name> query param, or Real DB URL in Firebase Console with https://<db-name>.firebaseio.com)`, parsedDbURL)
}

} else {
namespace = strings.Split(parsedDbURL.Host, ".")[0]
if namespace == "" {
return nil, fmt.Errorf(`invalid database URL: "%s". Database URL must be a valid URL to a Firebase Realtime Database instance (Emulator URL include ?ns=<db-name> query param, or Real DB URL in Firebase Console with https://<db-name>.firebaseio.com)`, parsedDbURL)
}
}
}

Expand Down