Skip to content

fix(messaging): correct comment #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix(messaging): correct comment #571

merged 1 commit into from
Jul 20, 2023

Conversation

sapuri
Copy link
Contributor

@sapuri sapuri commented Jul 18, 2023

Correct the comment on SendEachForMulticast.

lahirumaramba
lahirumaramba approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sapuri !

Doris-Ge
Doris-Ge approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Doris-Ge Doris-Ge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting the comment, @sapuri!

@lahirumaramba lahirumaramba merged commit c294161 into firebase:dev Jul 20, 2023
@sapuri sapuri deleted the fix-messaging-cmt branch July 21, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@Doris-Ge Doris-Ge Doris-Ge approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sapuri @lahirumaramba @Doris-Ge