feat(fcm): SendEach and SendEachForMulticast for FCM batch send
#551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SendEachForMulticastDryRun`
1. Add `SendEach`, `SendEachDryRun`, `SendEachForMulticast`,
`SendEachForMulticastDryRun`
2. Deprecate `SendAll`, `SendAllDryRun`, `SendMulticast`,
`SendMulticastDryRun`
`SendEach` vs `SendAll`
1. `SendEach` sends one HTTP request to V1 Send endpoint for each
message in the array.
`SendAll` sends only one HTTP request to V1 Batch Send endpoint
to send all messages in the array.
2. `SendEach` calls fcmClient.Send to send each message
and constructs a SendResponse with the returned message id or error.
`SendEach` uses sync.WaitGroup to execute all fcmClient.Send calls
asynchronously and wait for all of them to complete and construct a
BatchResponse with all SendResponses.
Therefore, unlike `SendAll`, `SendEach` does not always returns
an error for a total failure. It can also return a `BatchResponse`
with only errors in it.
`SendEachForMulticast` calls `SendEach` under the hood.
lahirumaramba
changed the title
SendEach and SendEachForMulticast for FCM batch sendSendEach and SendEachForMulticast for FCM batch send
lahirumaramba
requested changes
Apr 5, 2023
|
Done. Thank you for the reminder! |
|
Thank you @Doris-Ge! One more thing, it looks like |
|
Closing this PR because this fcm-batch-send branch was based off master not dev. This is causing problems merging into dev. |
|
#552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.