Skip to content

Conversation

castor-rtzr
Copy link
Contributor

Update comment align with #453

@google-cla
Copy link

google-cla bot commented Sep 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hiranya911
Copy link
Contributor

@castor-rtzr thanks for the PR. Please sign the CLA before we can accept it.

@castor-rtzr
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @castor-rtzr. I think there's a trailing space in one of the lines which is causing an error. Can you fix that or just run gofmt on the file to reformat it?

@castor-rtzr
Copy link
Contributor Author

Thanks for the PR @castor-rtzr. I think there's a trailing space in one of the lines which is causing an error. Can you fix that or just run gofmt on the file to reformat it?

Fixed it! :-)

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@hiranya911 hiranya911 merged commit 717412a into firebase:dev Sep 13, 2021
@castor-rtzr castor-rtzr deleted the fix-comment branch September 14, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants