Skip to content

Conversation

lahirumaramba
Copy link
Member

  • Add nightly build workflow.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM with a suggestion for future improvement.

FIREBASE_SERVICE_ACCT_KEY: ${{ secrets.FIREBASE_SERVICE_ACCT_KEY }}
FIREBASE_API_KEY: ${{ secrets.FIREBASE_API_KEY }}

- name: Send email on failure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking if we should try and reduce the duplication here. Something like:

- name: Generate email text
  if: failure() || cancelled()
  run: ./.github/scripts/generate_email.sh
  env:
    WORKFLOW_CANCELLED: ${{ cancelled() }}
    WORKFLOW_FAILED: ${{ failure() }}

- name: Send email
  uses: firebase/firebase-admin-node/.github/actions/send-email@master
  ...

No need to do this urgently. But something to think about.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!
I will use one of the other repos to test this out first. Thanks!

@hiranya911 hiranya911 changed the base branch from master to dev August 13, 2021 20:50
@hiranya911
Copy link
Contributor

I've changed base branch to dev.

@lahirumaramba
Copy link
Member Author

I've changed base branch to dev.

Thank you!!

@google-cla
Copy link

google-cla bot commented Aug 13, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@lahirumaramba
Copy link
Member Author

@googlebot I fixed it.

@lahirumaramba lahirumaramba merged commit 4d3cc69 into dev Aug 17, 2021
@lahirumaramba lahirumaramba deleted the lm-nightly-builds branch August 17, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants