-
Notifications
You must be signed in to change notification settings - Fork 268
chore: Add nightly build workflow #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lahirumaramba
commented
Aug 13, 2021
- Add nightly build workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM with a suggestion for future improvement.
FIREBASE_SERVICE_ACCT_KEY: ${{ secrets.FIREBASE_SERVICE_ACCT_KEY }} | ||
FIREBASE_API_KEY: ${{ secrets.FIREBASE_API_KEY }} | ||
|
||
- name: Send email on failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking if we should try and reduce the duplication here. Something like:
- name: Generate email text
if: failure() || cancelled()
run: ./.github/scripts/generate_email.sh
env:
WORKFLOW_CANCELLED: ${{ cancelled() }}
WORKFLOW_FAILED: ${{ failure() }}
- name: Send email
uses: firebase/firebase-admin-node/.github/actions/send-email@master
...
No need to do this urgently. But something to think about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
I will use one of the other repos to test this out first. Thanks!
I've changed base branch to dev. |
Thank you!! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
94327c5
to
39b26af
Compare
@googlebot I fixed it. |