Skip to content

fix(auth): Removed MultiFactoryID public type #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

fix(auth): Removed MultiFactoryID public type #431

merged 1 commit into from
Mar 31, 2021

Conversation

hiranya911
Copy link
Contributor

Adds to the changes made in #422. This PR:

  • Removed MultiFactorID type and Phone constant value.
  • Adding a check to gracefully handle unsupported auth factors.

Part of go/firebase-mfa-go

@hiranya911
Copy link
Contributor Author

@jasperkuperus FYI

@jasperkuperus
Copy link
Contributor

jasperkuperus commented Mar 31, 2021 •
edited
Loading

Looks good. Any idea when this will be released?

lahirumaramba
lahirumaramba approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hiranya! LGTM!

@hiranya911 hiranya911 merged commit 11d5daa into dev Mar 31, 2021
@hiranya911 hiranya911 deleted the hkj-mfa branch March 31, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiranya911 @jasperkuperus @lahirumaramba