Skip to content

fix(rtdb): enable support for firebasedatabase.app #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2021
Merged

fix(rtdb): enable support for firebasedatabase.app #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cace017
fix: enable support for firebasedatabase.app
thameezb Mar 13, 2021
9c436d4
fix: remove static URL check
thameezb Apr 27, 2021
f8b195e
Merge branch 'dev' into fix/enableSupportForEU
hiranya911 May 14, 2021
a8207e5
Merge branch 'dev' into fix/enableSupportForEU
hiranya911 May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions db/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ func NewClient(ctx context.Context, c *internal.DatabaseConfig) (*Client, error)
return nil, err
} else if p.Scheme != "https" {
return nil, fmt.Errorf("invalid database URL: %q; want scheme: %q", c.URL, "https")
} else if !strings.HasSuffix(p.Host, ".firebaseio.com") {
return nil, fmt.Errorf("invalid database URL: %q; want host: %q", c.URL, "firebaseio.com")
}

var ao []byte
Expand Down
21 changes: 20 additions & 1 deletion db/db_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,31 @@ func TestNewClientAuthOverrides(t *testing.T) {
}
}

func TestValidURLS(t *testing.T) {
cases := []string{
"https://test-db.firebaseio.com",
"https://test-db.firebasedatabase.app",
}
for _, tc := range cases {
c, err := NewClient(context.Background(), &internal.DatabaseConfig{
Opts: testOpts,
URL: tc,
})
if err != nil {
t.Fatal(err)
}
if c.url != tc {
t.Errorf("NewClient(%v).url = %q; want = %q", tc, c.url, testURL)
}
}
}

func TestInvalidURL(t *testing.T) {
cases := []string{
"",
"foo",
"http://db.firebaseio.com",
"https://firebase.google.com",
"http://firebase.google.com",
}
for _, tc := range cases {
c, err := NewClient(context.Background(), &internal.DatabaseConfig{
Expand Down