fix(fcm): Allow for override of batch endpoint URL #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng for the FCM batch endpoint (firebase#385)
hiranya911
approved these changes
Aug 7, 2020
hiranya911
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #385.
Of note, because there is only one HTTP client involved in sending both single messages and batch messages, the
WithEndpoint()override will apply to both endpoints, even though the paths of the original endpoints differ. There's no easy way around this without refactoring of the code to use two different HTTP clients and in practice, somebody wanting to override this endpoint can likely cope with this limitation by dealing with the different requests based on the incoming content.