[chore] Release 4.0.0 - take 2 #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsgowman
approved these changes
Jun 16, 2020
| var getUsersResult *auth.UserRecord | ||
| for i := 0; i < 3; i++ { | ||
| var err error | ||
| getUsersResult, err = client.GetUser(context.Background(), userRecord.UID) |
There was a problem hiding this comment.
nit: Could you use := here and eliminate the var err statement on the previous line?
Optional.
There was a problem hiding this comment.
That also declares a new getUsersResult variable in the nested scope. We want to reuse the one defined outside the for loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a flaky auth integration test by retrying the
GetUser()API call a few times with a small delay.