Skip to content

chore: Adding a CI job to build in non-module (gopath) mode #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2020
Merged

chore: Adding a CI job to build in non-module (gopath) mode #381

merged 3 commits into from
Jun 12, 2020

Conversation

hiranya911
Copy link
Contributor

Checks out source into GOPATH/src and tries to compile as a non-module package.

@hiranya911 hiranya911 requested a review from lahirumaramba June 12, 2020 19:40
lahirumaramba
lahirumaramba approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@hiranya911 hiranya911 merged commit 1f197e8 into dev Jun 12, 2020
@hiranya911 hiranya911 deleted the hkj-gopath-build branch June 12, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @lahirumaramba