Skip to content

[chore] Release 3.13.0 take 2 #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020
Merged

[chore] Release 3.13.0 take 2 #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions integration/auth/user_mgt_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,17 @@ func TestDeleteUser(t *testing.T) {
}

func TestDeleteUsers(t *testing.T) {
// Deletes users slowly. There's currently a 1qps limitation on this API.
// Without this helper, the integration tests occasionally hit that limit
// and fail.
//
// TODO(rsgowman): Remove this function when/if the 1qps limitation is
// relaxed.
slowDeleteUsers := func(ctx context.Context, uids []string) (*auth.DeleteUsersResult, error) {
time.Sleep(1 * time.Second)
return client.DeleteUsers(ctx, uids)
}

// Ensures the specified users don't exist. Expected to be called after
// deleting the users to ensure the delete method worked.
ensureUsersNotFound := func(t *testing.T, uids []string) {
Expand Down Expand Up @@ -546,7 +557,7 @@ func TestDeleteUsers(t *testing.T) {
newUserWithParams(t).UID, newUserWithParams(t).UID, newUserWithParams(t).UID,
}

result, err := client.DeleteUsers(context.Background(), uids)
result, err := slowDeleteUsers(context.Background(), uids)
if err != nil {
t.Fatalf("DeleteUsers([valid_ids]) error %v; want nil", err)
}
Expand All @@ -566,7 +577,7 @@ func TestDeleteUsers(t *testing.T) {

t.Run("deletes users that exist even when non-existing users also specified", func(t *testing.T) {
uids := []string{newUserWithParams(t).UID, "uid-that-doesnt-exist"}
result, err := client.DeleteUsers(context.Background(), uids)
result, err := slowDeleteUsers(context.Background(), uids)
if err != nil {
t.Fatalf("DeleteUsers(uids) error %v; want nil", err)
}
Expand All @@ -586,7 +597,7 @@ func TestDeleteUsers(t *testing.T) {

t.Run("is idempotent", func(t *testing.T) {
deleteUserAndEnsureSuccess := func(t *testing.T, uids []string) {
result, err := client.DeleteUsers(context.Background(), uids)
result, err := slowDeleteUsers(context.Background(), uids)
if err != nil {
t.Fatalf("DeleteUsers(uids) error %v; want nil", err)
}
Expand Down