Skip to content

feat(auth): add auth.IsInvalidEmail function, fixes #295 #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

feat(auth): add auth.IsInvalidEmail function, fixes #295 #299

merged 1 commit into from
Nov 7, 2019

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Nov 7, 2019 •
edited by hiranya911
Loading

I added new IsInvalidEmail function to handle INVALID_EMAIL error.
It fixes #295

RELEASE NOTE: Added a new IsInvalidEmail() error checking function.

hiranya911
hiranya911 approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 changed the title add auth.IsInvalidEmail function, fixes #295 feat(auth): add auth.IsInvalidEmail function, fixes #295 Nov 7, 2019
@hiranya911 hiranya911 self-assigned this Nov 7, 2019
@hiranya911 hiranya911 merged commit 17d8615 into firebase:dev Nov 7, 2019
@shogo82148 shogo82148 deleted the add-is-invalid-email branch November 24, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hiranya911 hiranya911

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shogo82148 @hiranya911