Implementing support for APNS content-mutable field #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bklimt
approved these changes
Apr 5, 2018
messaging/messaging.go
Outdated
| apsAlias: (*apsAlias)(a), | ||
| } | ||
|
|
||
| func (a *Aps) standardFields() map[string]interface{} { |
There was a problem hiding this comment.
Would be nice to add a short comment for this function and mention that it doesn't include CustomData.
hiranya911
added a commit
that referenced
this pull request
Apr 17, 2018
* Changlog updates (#123) * Reading FCM error code from details section (#127) * Adding additional details to the error message when available (#129) * Implementing support for APNS content-mutable field (#126) * Implementing support for APNS content-mutable field * Corrected the mutable-content option name * Renamed CustomFields to CustomData * Added comment * Implementing Functions to Test Error Codes (#131) * Adding error codes to the auth package * Added error codes for messaging * Responding to review feedback; Updated changelog * Add Go import comments. (#132) * Bumped version to 2.7.0 (#133) * Bumped version to 2.7.0 * Updated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for
content-mutableoption in APNS messages.