Updated Comparison of SupportedMediaTypes to use the MediaType descripti... #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption so it can support parameters This is to support custom media types that contain parameters. For example: application/vnd.mine+json and application/vnd.mine+json; version 2 those are effectively the same media types but the second contain a 'version' parameter. The existing comparison will not match it with the Supported ones but the updated version will.
|
Thanks - this is a good change but it needs to be applied to |
filipw
added a commit
that referenced
this pull request
Dec 29, 2016
Merged
filipw
added a commit
that referenced
this pull request
Dec 29, 2016
fvanzee
pushed a commit
to fvanzee/Strathweb.CacheOutput
that referenced
this pull request
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have made this change when comparing media type header values in order to support custom media types that contain parameters. For example consider:
application/vnd.mine+json
and
application/vnd.mine+json; version 2
Those are effectively the same media types but the second contain a 'version' parameter. The existing comparison will not match it with the supported ones but the updated version will.