IoCDownloader: older_than param #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisTrezzini
approved these changes
Oct 10, 2025
| return | ||
|
|
||
| if ( | ||
| not self.newer_than and not self.older_than |
Contributor
There was a problem hiding this comment.
I think this might be an error? Older than isn't relevant to the stopping condition?
jashdalvi
approved these changes
Oct 10, 2025
| :param session: The authenticated session to use to make the api calls | ||
| :param newer_than: Only articles newer than this parameter will be used. If None only one call will be make, | ||
| and the continuation will be ignored | ||
| :param older_than: Only articles older than this parameter will be used. If None only one call will be make, |
There was a problem hiding this comment.
Suggested change
| :param older_than: Only articles older than this parameter will be used. If None only one call will be make, | |
| :param older_than: Only articles older than this parameter will be used. If None only one call will be made, |
| if self.older_than: | ||
| params["olderThan"] = int(self.older_than.timestamp()) | ||
|
|
||
| resp = self.session.make_api_request(f"{self.RELATIVE_URL}", params=params) |
There was a problem hiding this comment.
Suggested change
| resp = self.session.make_api_request(f"{self.RELATIVE_URL}", params=params) | |
| resp = self.session.make_api_request(self.RELATIVE_URL, params=params) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.