-
-
Notifications
You must be signed in to change notification settings - Fork 1k
docs: split custom Faker instance example #3585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3585 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 2894 2894
Lines 222262 222262
Branches 930 931 +1
=======================================
Hits 222195 222195
Misses 67 67
🚀 New features to boost your workflow:
|
Yes, that would require some changes to the api-docs scripts. Class-Level: faker/scripts/apidocs/output/page.ts Line 76 in 61e4c45
Method-Level: faker/scripts/apidocs/output/page.ts Line 195 in 61e4c45
Note: The later might have impact on the refresh examples button. |
|
I think it's a bit tricky to read partly because of the other commented out code. (Like the CJS imports and the seed). So comments are being used both as a header and to show optional alternatives. Maybe some of the commented lines could be removed or split to another example. |



Currently two examples are joined and it looks quite confusing.