Skip to content

Conversation

javache
Copy link
Member

@javache javache commented Aug 20, 2025

Summary

passChildrenWhenCloningPersistedNodes was evaluated internally at Meta and all known regressions have been resolved. This is a valuable performance improvement for React Native performance and it should be rolled out everywhere.

This change does not have user-visible behaviour, it just affects how Fabric keeps track of the ShadowTree internally.

How did you test this change?

Unit tests updated

@meta-cla meta-cla bot added the CLA Signed label Aug 20, 2025
@react-sizebot
Copy link

Comparing: 3e20dc8...b388122

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.18 kB 530.18 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.81 kB 655.81 kB = 115.30 kB 115.30 kB
facebook-www/ReactDOM-prod.classic.js = 675.58 kB 675.58 kB = 118.54 kB 118.54 kB
facebook-www/ReactDOM-prod.modern.js = 666.00 kB 666.00 kB = 116.86 kB 116.87 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-dev.js +0.21% 647.03 kB 648.39 kB +0.07% 104.97 kB 105.04 kB
react-native/implementations/ReactFabric-prod.fb.js = 381.54 kB 380.70 kB = 65.95 kB 65.80 kB

Generated by 🚫 dangerJS against b388122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants