Skip to content

Conversation

kassens
Copy link
Member

@kassens kassens commented May 27, 2025

We need to do some more testing here.

Reverts #33357

@kassens kassens requested a review from rickhanlonii May 27, 2025 21:05
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 27, 2025
@react-sizebot
Copy link

Comparing: f9ae0a4...21b5593

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.83 kB 529.83 kB = 93.52 kB 93.52 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 650.93 kB 650.93 kB = 114.65 kB 114.65 kB
facebook-www/ReactDOM-prod.classic.js +0.27% 674.07 kB 675.87 kB +0.31% 118.55 kB 118.93 kB
facebook-www/ReactDOM-prod.modern.js +0.26% 664.42 kB 666.15 kB +0.32% 116.94 kB 117.31 kB
facebook-www/ReactTestRenderer-dev.classic.js = 620.74 kB 588.75 kB = 100.38 kB 95.09 kB
facebook-www/ReactTestRenderer-dev.modern.js = 620.74 kB 588.75 kB = 100.38 kB 95.09 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactIs-prod.classic.js +1.60% 5.80 kB 5.89 kB +1.11% 1.36 kB 1.37 kB
facebook-www/ReactIs-prod.modern.js +1.60% 5.80 kB 5.89 kB +1.11% 1.36 kB 1.37 kB
facebook-www/ReactIs-dev.classic.js +1.33% 6.40 kB 6.49 kB +1.08% 1.39 kB 1.40 kB
facebook-www/ReactIs-dev.modern.js +1.33% 6.40 kB 6.49 kB +1.08% 1.39 kB 1.40 kB
facebook-www/React-prod.modern.js +0.70% 20.87 kB 21.01 kB +0.45% 5.34 kB 5.37 kB
facebook-www/React-prod.classic.js +0.70% 20.87 kB 21.01 kB +0.45% 5.34 kB 5.37 kB
facebook-www/React-profiling.modern.js +0.69% 21.30 kB 21.45 kB +0.42% 5.42 kB 5.45 kB
facebook-www/React-profiling.classic.js +0.69% 21.30 kB 21.45 kB +0.42% 5.42 kB 5.45 kB
facebook-www/JSXDEVRuntime-dev.classic.js +0.64% 13.28 kB 13.37 kB +0.25% 3.59 kB 3.60 kB
facebook-www/JSXDEVRuntime-dev.modern.js +0.64% 13.28 kB 13.37 kB +0.25% 3.59 kB 3.60 kB
facebook-www/ReactART-prod.classic.js +0.48% 385.90 kB 387.76 kB +0.48% 64.61 kB 64.92 kB
facebook-www/ReactART-prod.modern.js +0.48% 375.98 kB 377.77 kB +0.46% 62.99 kB 63.28 kB
facebook-www/ReactReconciler-prod.classic.js +0.39% 508.32 kB 510.28 kB +0.41% 81.06 kB 81.39 kB
facebook-www/ReactReconciler-prod.modern.js +0.38% 498.08 kB 499.98 kB +0.38% 79.49 kB 79.80 kB
facebook-www/React-dev.modern.js +0.34% 55.96 kB 56.14 kB +0.12% 12.29 kB 12.31 kB
facebook-www/React-dev.classic.js +0.34% 55.96 kB 56.15 kB +0.12% 12.29 kB 12.31 kB
facebook-www/ReactART-dev.modern.js +0.30% 719.87 kB 722.02 kB +0.30% 111.78 kB 112.11 kB
facebook-www/ReactART-dev.classic.js +0.29% 729.36 kB 731.51 kB +0.29% 113.54 kB 113.86 kB
facebook-www/ReactDOM-prod.classic.js +0.27% 674.07 kB 675.87 kB +0.31% 118.55 kB 118.93 kB
facebook-www/ReactReconciler-dev.modern.js +0.27% 836.09 kB 838.31 kB +0.26% 129.47 kB 129.81 kB
facebook-www/ReactReconciler-dev.classic.js +0.26% 845.29 kB 847.51 kB +0.25% 131.25 kB 131.58 kB
facebook-www/ReactDOMTesting-prod.classic.js +0.26% 688.48 kB 690.27 kB +0.28% 122.16 kB 122.51 kB
facebook-www/ReactDOM-prod.modern.js +0.26% 664.42 kB 666.15 kB +0.32% 116.94 kB 117.31 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.26% 678.82 kB 680.55 kB +0.30% 120.58 kB 120.95 kB
facebook-www/ReactDOM-profiling.modern.js +0.24% 736.33 kB 738.09 kB +0.28% 126.63 kB 126.99 kB
facebook-www/ReactDOM-profiling.classic.js +0.24% 744.38 kB 746.13 kB +0.27% 127.94 kB 128.28 kB
facebook-www/ReactTestRenderer-dev.classic.js = 620.74 kB 588.75 kB = 100.38 kB 95.09 kB
facebook-www/ReactTestRenderer-dev.modern.js = 620.74 kB 588.75 kB = 100.38 kB 95.09 kB

Generated by 🚫 dangerJS against 21b5593

@kassens kassens merged commit 283f87f into main May 27, 2025
246 checks passed
github-actions bot pushed a commit that referenced this pull request May 27, 2025
We need to do some more testing here.

Reverts #33357

DiffTrain build for [283f87f](283f87f)
github-actions bot pushed a commit to code/lib-react that referenced this pull request May 28, 2025
We need to do some more testing here.

Reverts facebook#33357

DiffTrain build for [283f87f](facebook@283f87f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants