Skip to content

[flags] Cleanup enableUseMemoCacheHook #31767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 14, 2024
Merged

[flags] Cleanup enableUseMemoCacheHook #31767

merged 6 commits into from
Dec 14, 2024

Conversation

rickhanlonii
Copy link
Member

Based off #31766

This has already landed everywhere.

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:41pm

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Dec 13, 2024
@react-sizebot
Copy link

react-sizebot commented Dec 13, 2024 •
edited
Loading

Comparing: 1520802...36e9041

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.08% 510.34 kB 510.72 kB +0.17% 91.33 kB 91.48 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.08% 515.25 kB 515.66 kB +0.19% 92.02 kB 92.19 kB
facebook-www/ReactDOM-prod.classic.js = 595.18 kB 595.04 kB = 105.01 kB 105.00 kB
facebook-www/ReactDOM-prod.modern.js = 585.44 kB 585.31 kB = 103.45 kB 103.44 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server.production.js = 122.53 kB 122.28 kB = 21.58 kB 21.50 kB
oss-stable-semver/react-server/cjs/react-server.production.js = 109.13 kB 108.88 kB = 19.77 kB 19.68 kB
oss-stable/react-server/cjs/react-server.production.js = 109.13 kB 108.88 kB = 19.77 kB 19.68 kB

Generated by 🚫 dangerJS against 8cc0a1b

@rickhanlonii rickhanlonii changed the title Remove enableUseMemoCacheHook [flags] Cleanup enableUseMemoCacheHook Dec 13, 2024
josephsavona
josephsavona approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay thank you!

@rickhanlonii rickhanlonii merged commit 2e25ee3 into facebook:main Dec 14, 2024
187 checks passed
@rickhanlonii rickhanlonii deleted the rh/rm-ff-uMC branch December 14, 2024 16:11
github-actions bot pushed a commit that referenced this pull request Dec 14, 2024
@rickhanlonii
[flags] Cleanup enableUseMemoCacheHook (#31767)
eccdc2d 
Based off #31766

This has already landed everywhere.

DiffTrain build for [2e25ee3](2e25ee3)
github-actions bot pushed a commit that referenced this pull request Dec 14, 2024
@rickhanlonii
[flags] Cleanup enableUseMemoCacheHook (#31767)
f161343 
Based off #31766

This has already landed everywhere.

DiffTrain build for [2e25ee3](2e25ee3)
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
dai-shi
dai-shi reviewed Jan 14, 2025
View reviewed changes
packages/react-server/src/ReactFizzHooks.js
@@ -859,6 +858,7 @@ export const HooksDispatcher: Dispatcher = supportsClientAPIs
useActionState,
useFormState: useActionState,
useHostTransitionStatus,
useMemoCache,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii You seem to have forgotten to add this after L837. ☝️

@eps1lon eps1lon mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsavona josephsavona josephsavona approved these changes

@kassens kassens Awaiting requested review from kassens

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

+1 more reviewer

@dai-shi dai-shi dai-shi left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @react-sizebot @dai-shi @josephsavona @facebook-github-bot