Add a regression test for Force unwind work loop during selective hyd… #25867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
tyao1
commented
Dec 10, 2022
| TODO_scheduleIdleDOMSchedulerTask(() => { | ||
| root.render(<App a="AA" />); | ||
| }); | ||
| expect(Scheduler).toFlushAndYieldThrough(['App', 'AA', 'DefaultContext']); |
There was a problem hiding this comment.
DefaultContext becomes SiblingContext in #25695
|
Comparing: b14d7fa...12b14c4 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
tyao1
added a commit
that referenced
this pull request
Dec 15, 2022
This PR includes the previously reverted #25695 and #25754, and the fix for the regression test added in #25867. Tested internally with a previous failed test, and it's passing now. Co-authored-by: Andrew Clark <[email protected]>
|
Merged in #25876 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
This PR includes the previously reverted #25695 and #25754, and the fix for the regression test added in #25867. Tested internally with a previous failed test, and it's passing now. Co-authored-by: Andrew Clark <[email protected]> DiffTrain build for [7efa9e5](7efa9e5) [View git log for this commit](https://github.com/facebook/react/commits/7efa9e59707b341f10fab79724e0fca373187925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ration #25695
Summary
#25695 caused a bug in context and this PR adds a regression test.