Skip to content

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented May 25, 2021

Enables enableProfilerCommitHooks (#17910, RFC 139) and enableProfilerNestedUpdatePhase (#20163) for release externally. These flags have been enabled and used within Facebook for months without reported problems.

enableProfilerCommitHooks and enableProfilerNestedUpdatePhase
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 25, 2021
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sizebot
Copy link

sizebot commented May 25, 2021

Comparing: 0ae5290...63e1253

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 126.00 kB 126.00 kB = 40.41 kB 40.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 128.82 kB 128.82 kB = 41.35 kB 41.35 kB
facebook-www/ReactDOM-prod.classic.js = 406.09 kB 406.09 kB = 75.11 kB 75.11 kB
facebook-www/ReactDOM-prod.modern.js = 394.46 kB 394.46 kB = 73.29 kB 73.29 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.09 kB 406.09 kB = 75.11 kB 75.11 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +3.42% 245.25 kB 253.64 kB +2.46% 45.11 kB 46.22 kB
react-native/implementations/ReactFabric-profiling.js +3.03% 278.02 kB 286.45 kB +2.30% 49.78 kB 50.92 kB
react-native/implementations/ReactFabric-profiling.fb.js +3.03% 278.06 kB 286.49 kB +2.30% 49.76 kB 50.91 kB
react-native/implementations/ReactNativeRenderer-profiling.js +2.95% 284.97 kB 293.37 kB +2.29% 51.18 kB 52.35 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +2.95% 285.00 kB 293.40 kB +2.28% 51.17 kB 52.33 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js +2.48% 92.94 kB 95.24 kB +2.31% 28.65 kB 29.31 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +2.37% 97.20 kB 99.50 kB +2.25% 30.09 kB 30.76 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +3.42% 245.25 kB 253.64 kB +2.46% 45.11 kB 46.22 kB
react-native/implementations/ReactFabric-profiling.js +3.03% 278.02 kB 286.45 kB +2.30% 49.78 kB 50.92 kB
react-native/implementations/ReactFabric-profiling.fb.js +3.03% 278.06 kB 286.49 kB +2.30% 49.76 kB 50.91 kB
react-native/implementations/ReactNativeRenderer-profiling.js +2.95% 284.97 kB 293.37 kB +2.29% 51.18 kB 52.35 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +2.95% 285.00 kB 293.40 kB +2.28% 51.17 kB 52.33 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js +2.48% 92.94 kB 95.24 kB +2.31% 28.65 kB 29.31 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +2.37% 97.20 kB 99.50 kB +2.25% 30.09 kB 30.76 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js +1.89% 626.65 kB 638.53 kB +1.53% 132.79 kB 134.83 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +1.89% 597.45 kB 608.74 kB +1.54% 131.36 kB 133.38 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +1.85% 609.16 kB 620.45 kB +1.56% 132.42 kB 134.48 kB
oss-stable/react-art/cjs/react-art.development.js +1.85% 611.06 kB 622.35 kB +1.49% 133.65 kB 135.63 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js +1.85% 643.43 kB 655.30 kB +1.48% 136.20 kB 138.21 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +1.84% 613.38 kB 624.67 kB +1.48% 134.71 kB 136.70 kB
facebook-www/ReactTestRenderer-dev.classic.js +1.82% 621.83 kB 633.13 kB +1.53% 133.96 kB 136.00 kB
facebook-www/ReactTestRenderer-dev.modern.js +1.82% 621.84 kB 633.14 kB +1.53% 133.96 kB 136.01 kB
oss-experimental/react-art/cjs/react-art.development.js +1.78% 633.52 kB 644.81 kB +1.45% 138.30 kB 140.31 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +1.73% 669.92 kB 681.51 kB +1.41% 143.50 kB 145.52 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js +1.72% 129.26 kB 131.47 kB +1.46% 41.39 kB 42.00 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js +1.70% 129.23 kB 131.43 kB +1.38% 42.08 kB 42.66 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +1.67% 692.57 kB 704.17 kB +1.32% 148.19 kB 150.15 kB
oss-stable/react-art/umd/react-art.development.js +1.67% 711.84 kB 723.71 kB +1.34% 151.81 kB 153.84 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js +1.66% 133.88 kB 136.10 kB +1.52% 42.92 kB 43.58 kB
react-native/implementations/ReactFabric-dev.js +1.65% 684.12 kB 695.44 kB +1.44% 148.06 kB 150.20 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js +1.64% 133.82 kB 136.01 kB +1.31% 43.60 kB 44.17 kB
react-native/implementations/ReactFabric-dev.fb.js +1.62% 697.39 kB 708.71 kB +1.45% 150.18 kB 152.36 kB
oss-experimental/react-art/umd/react-art.development.js +1.61% 735.66 kB 747.53 kB +1.29% 156.57 kB 158.58 kB
react-native/implementations/ReactNativeRenderer-dev.js +1.61% 702.54 kB 713.84 kB +1.34% 152.69 kB 154.74 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +1.58% 715.78 kB 727.08 kB +1.38% 154.82 kB 156.95 kB
oss-stable/react-dom/umd/react-dom.development.js +1.22% 975.37 kB 987.24 kB +0.95% 213.28 kB 215.30 kB
oss-stable/react-dom/cjs/react-dom.development.js +1.22% 928.72 kB 940.01 kB +0.96% 210.74 kB 212.75 kB
oss-experimental/react-dom/umd/react-dom.development.js +1.19% 1,001.27 kB 1,013.14 kB +0.92% 218.30 kB 220.31 kB
oss-experimental/react-dom/cjs/react-dom.development.js +1.18% 953.15 kB 964.44 kB +0.94% 215.72 kB 217.74 kB

Generated by 🚫 dangerJS against 63e1253

@bvaughn bvaughn merged commit 6405efc into facebook:master May 25, 2021
@bvaughn bvaughn deleted the enable-new-profiler-apis branch May 25, 2021 21:32
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jun 7, 2021
Summary:
- **[0eea57724](facebook/react@0eea57724 )**: Fix typo in comment (accumlated → accumulated) ([#21637](facebook/react#21637)) //<ithinker5>//
- **[0706162ba](facebook/react@0706162ba )**: Fix typo in comment (environement → environment) ([#21635](facebook/react#21635)) //<niexq>//
- **[9d17b562b](facebook/react@9d17b562b )**: Fix typo in comment (satsify → satisfy) ([#21629](facebook/react#21629)) //<niexq>//
- **[b610fec00](facebook/react@b610fec00 )**: fix comments: expiration time -> lanes ([#21551](facebook/react#21551)) //<Shannon Feng>//
- **[cc4d24ab0](facebook/react@cc4d24ab0 )**: [Fizz] Always call flush() if it exists ([#21625](facebook/react#21625)) //<Dan Abramov>//
- **[e0d9b2899](facebook/react@e0d9b2899 )**: [Fizz] Minor Fixes for Warning Parity ([#21618](facebook/react#21618)) //<Sebastian Markbåge>//
- **[1b7b3592f](facebook/react@1b7b3592f )**: [Fizz] Implement Component Stacks in DEV for warnings ([#21610](facebook/react#21610)) //<Sebastian Markbåge>//
- **[39f007489](facebook/react@39f007489 )**: Make enableSuspenseLayoutEffectSemantics static for www ([#21617](facebook/react#21617)) //<Brian Vaughn>//
- **[8f3794276](facebook/react@8f3794276 )**: Prepare semver (`latest`) releases in CI ([#21615](facebook/react#21615)) //<Andrew Clark>//
- **[8b4201535](facebook/react@8b4201535 )**: Devtools: add feature to trigger an error boundary ([#21583](facebook/react#21583)) //<Bao Pham>//
- **[154a8cf32](facebook/react@154a8cf32 )**: Fix reference to wrong variable //<Andrew Clark>//
- **[6736a38b9](facebook/react@6736a38b9 )**: Add single source of truth for package versions ([#21608](facebook/react#21608)) //<Andrew Clark>//
- **[86715efa2](facebook/react@86715efa2 )**: Resolve the true entry point during tests ([#21505](facebook/react#21505)) //<Sebastian Markbåge>//
- **[a8a4742f1](facebook/react@a8a4742f1 )**: Convert ES6/TypeScript/CoffeeScript Tests to createRoot + act ([#21598](facebook/react#21598)) //<Sebastian Markbåge>//
- **[1d3558965](facebook/react@1d3558965 )**: Disable deferRenderPhaseUpdateToNextBatch by default ([#21605](facebook/react#21605)) //<Sebastian Markbåge>//
- **[a8964649b](facebook/react@a8964649b )**: Delete an unused field ([#21415](facebook/react#21415)) //<okmttdhr>//
- **[76f85b3e5](facebook/react@76f85b3e5 )**: Expose Fizz in stable builds ([#21602](facebook/react#21602)) //<Dan Abramov>//
- **[e16d61c30](facebook/react@e16d61c30 )**: [Offscreen] Mount/unmount layout effects ([#21386](facebook/react#21386)) //<Andrew Clark>//
- **[63091939b](facebook/react@63091939b )**: OSS feature flag updates ([#21597](facebook/react#21597)) //<Brian Vaughn>//
- **[efbd69b27](facebook/react@efbd69b27 )**:  Define global __WWW__ = true flag during www tests ([#21504](facebook/react#21504)) //<Sebastian Markbåge>//
- **[28625c6f4](facebook/react@28625c6f4 )**: Disable strict effects for legacy roots (again) ([#21591](facebook/react#21591)) //<Brian Vaughn>//
- **[3c2341416](facebook/react@3c2341416 )**: Update jest to v26 ([#21574](facebook/react#21574)) //<Sebastian Silbermann>//
- **[0d493dcda](facebook/react@0d493dcda )**: Removed _debugID field from Fiber - Issue #21558 ([#21570](facebook/react#21570)) //<Pulkit Sharma>//
- **[7841d0695](facebook/react@7841d0695 )**: Enable the updater-tracking feature flag in more builds ([#21567](facebook/react#21567)) //<Brian Vaughn>//
- **[6405efc36](facebook/react@6405efc36 )**: Enabled Profiling feature flags for OSS release ([#21565](facebook/react#21565)) //<Brian Vaughn>//

Changelog:
[General][Changed] - React Native sync for revisions 2d8d133...0eea577

jest_e2e[run_all_tests]

Reviewed By: bvaughn

Differential Revision: D28932083

fbshipit-source-id: 012c1bfb857ed59d7283334d633f1cce8ec50360
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
* Enabled Profiling feature flags for OSS release

`enableProfilerCommitHooks` and `enableProfilerNestedUpdatePhase`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants